mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ddr: imx8m: add missing DDR clock rates
Date: Tue, 23 Jan 2024 13:15:18 +0100	[thread overview]
Message-ID: <20240123121518.y3bjxo3dbuapwcjm@pengutronix.de> (raw)
In-Reply-To: <e36eda7e-29fc-4e92-be4e-f8c58ec286e6@pengutronix.de>

On 24-01-23, Ahmad Fatoum wrote:
> On 23.01.24 11:04, Marco Felsch wrote:
> > On 24-01-22, Ahmad Fatoum wrote:
> >> ddrphy_init_set_dfi_clk() is called to translate a scalar clock rate
> >> as specified by board code into PLL parameters, which are configured.
> >>
> >> enum ddr_rate describes the possible DDR rates and so far
> >> ddrphy_init_set_dfi_clk() supported all of them, except for 2600 and
> >> 2376 MHz, rendering these two rates unusable.
> >>
> >> Fix this by adding support for them into ddrphy_init_set_dfi_clk.
> > 
> > Do we need to support this in TF-A as well for dvfs?
> 
> I don't know. I am not familiar with what needs to be done in TF-A
> to support DVFS for these frequencies. Do you know?

See dram_pll_init() within the TF-A code. Marek recently added the 3600
case.

Regards,
  Marco

> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > 
> > The barebox change itself lgtm, therefore:
> > 
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> > 
> >> ---
> >>  drivers/ddr/imx/imx8m_ddr_init.c | 6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/ddr/imx/imx8m_ddr_init.c b/drivers/ddr/imx/imx8m_ddr_init.c
> >> index 8b829645c063..d9a5d589f27b 100644
> >> --- a/drivers/ddr/imx/imx8m_ddr_init.c
> >> +++ b/drivers/ddr/imx/imx8m_ddr_init.c
> >> @@ -219,9 +219,9 @@ enum ddr_rate {
> >>  	DDR_3720,
> >>  	DDR_3200,
> >>  	DDR_3000,
> >> -	DDR_2600, /* Unused */
> >> +	DDR_2600,
> >>  	DDR_2400,
> >> -	DDR_2376, /* Unused */
> >> +	DDR_2376,
> >>  	DDR_1600,
> >>  	DDR_1000, /* Unused */
> >>  	DDR_1066,
> >> @@ -450,7 +450,9 @@ static void ddrphy_init_set_dfi_clk(struct dram_controller *dram, unsigned int d
> >>  	case 3720: drate = DDR_3720; break;
> >>  	case 3200: drate = DDR_3200; break;
> >>  	case 3000: drate = DDR_3000; break;
> >> +	case 2600: drate = DDR_2600; break;
> >>  	case 2400: drate = DDR_2400; break;
> >> +	case 2376: drate = DDR_2376; break;
> >>  	case 1600: drate = DDR_1600; break;
> >>  	case 1066: drate = DDR_1066; break;
> >>  	case 667: drate = DDR_667; break;
> >> -- 
> >> 2.39.2
> >>
> >>
> >>
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 



  reply	other threads:[~2024-01-23 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 14:13 Ahmad Fatoum
2024-01-23 10:04 ` Marco Felsch
2024-01-23 10:35   ` Ahmad Fatoum
2024-01-23 12:15     ` Marco Felsch [this message]
2024-02-08  7:35 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123121518.y3bjxo3dbuapwcjm@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox