mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] uncompress: add detected file type debug print
Date: Wed, 24 Jan 2024 15:22:43 +0100	[thread overview]
Message-ID: <20240124142243.cjds2eb2l3l2v5mm@pengutronix.de> (raw)
In-Reply-To: <20240124135842.pbpselwwytxri22q@pengutronix.de>

On 24-01-24, Marco Felsch wrote:
> On 24-01-24, Ahmad Fatoum wrote:
> > On 24.01.24 14:47, Marco Felsch wrote:
> > > This can be useful for developers.
> > > 
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > >  lib/uncompress.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/lib/uncompress.c b/lib/uncompress.c
> > > index e7a3ffde823e..48e8173501c6 100644
> > > --- a/lib/uncompress.c
> > > +++ b/lib/uncompress.c
> > > @@ -97,6 +97,8 @@ int uncompress(unsigned char *inbuf, int len,
> > >  		ft = file_detect_type(uncompress_buf, 32);
> > >  	}
> > >  
> > > +	pr_debug("Filetype detected: %s\n", file_type_to_string(ft));
> > 
> > Not that I mind, but do you know about the filetype command?
> 
> I used it to check the kernel image within a fit container.

After checking the code path which is a bit confusing, I see that I
didn't triggered the bootm path the image-fit path which uses the same
uncompression algorithm. So the cover-letter title is incorrect.

Regards,
  Marco

> 
> Regards,
>   Marco
> 
> 
> 
> > 
> > > +
> > >  	switch (ft) {
> > >  #ifdef CONFIG_BZLIB
> > >  	case filetype_bzip2:
> > 
> > -- 
> > Pengutronix e.K.                           |                             |
> > Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> > 
> > 
> 
> 



  reply	other threads:[~2024-01-24 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 13:47 [PATCH 0/3] Add bootm ZSTD support Marco Felsch
2024-01-24 13:47 ` [PATCH 1/3] filetype: add zstd support Marco Felsch
2024-01-24 13:47 ` [PATCH 2/3] bootm: add support to boot ZSTD compressed images Marco Felsch
2024-01-24 13:47 ` [PATCH 3/3] uncompress: add detected file type debug print Marco Felsch
2024-01-24 13:56   ` Ahmad Fatoum
2024-01-24 13:58     ` Marco Felsch
2024-01-24 14:22       ` Marco Felsch [this message]
2024-01-25  7:38 ` [PATCH 0/3] Add bootm ZSTD support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124142243.cjds2eb2l3l2v5mm@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox