From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Stefan Kerkmann <s.kerkmann@pengutronix.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v2 0/2] of: fdt: fix memory leak and oob writes in fdt_ensure_space
Date: Thu, 01 Feb 2024 12:28:48 +0100 [thread overview]
Message-ID: <20240201-fix-fdt-memory-safety-v2-0-267b7b8813fd@pengutronix.de> (raw)
I have encountered the oob write while attempting to modify a large FIT
image with of_property. While hunting for the root cause I noticed that
there is a potential memory leak in fdt_ensure_space as well. Both is
fixed in this series.
Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
Changes in v2:
- Review feedback from Ahmad and Sascha
- Link to v1: https://lore.kernel.org/r/20240131-fix-fdt-memory-safety-v1-0-3d3a2c797eec@pengutronix.de
---
Stefan Kerkmann (2):
of: fdt: fix memory leak in fdt_ensure_space
of: fdt: fix oob writes with large fdt properties
drivers/of/fdt.c | 32 +++++++++++++++++++++++++-------
1 file changed, 25 insertions(+), 7 deletions(-)
---
base-commit: cecd3fbea3550532d2175bc13aa479a45e605da0
change-id: 20240131-fix-fdt-memory-safety-b06f9164d953
Best regards,
--
Stefan Kerkmann <s.kerkmann@pengutronix.de>
next reply other threads:[~2024-02-01 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 11:28 Stefan Kerkmann [this message]
2024-02-01 11:28 ` [PATCH v2 1/2] of: fdt: fix memory leak " Stefan Kerkmann
2024-02-01 11:28 ` [PATCH v2 2/2] of: fdt: fix oob writes with large fdt properties Stefan Kerkmann
2024-02-01 15:10 ` [PATCH v2 0/2] of: fdt: fix memory leak and oob writes in fdt_ensure_space Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201-fix-fdt-memory-safety-v2-0-267b7b8813fd@pengutronix.de \
--to=s.kerkmann@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox