From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: ske@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/3] firmware: arm_scmi: call device driver remove if defined
Date: Thu, 15 Feb 2024 11:33:53 +0100 [thread overview]
Message-ID: <20240215103353.2799723-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240215103353.2799723-1-a.fatoum@pengutronix.de>
We don't have SCMI driver remove callbacks like Linux does, so
scmi_bus_type.remove is just an empty function. As no SCMI driver in
barebox populates its remove callback, we can just replace this empty
implementation by the default one of calling driver::remove.
This has the added benefit that the SCMI devices won't be printed on
shutdown when CONFIG_DEBUG_PROBES=y is enabled.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/firmware/arm_scmi/bus.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
index 5a80911119e0..1d9a0f089b44 100644
--- a/drivers/firmware/arm_scmi/bus.c
+++ b/drivers/firmware/arm_scmi/bus.c
@@ -206,15 +206,10 @@ static int scmi_dev_probe(struct device *dev)
return scmi_drv->probe(scmi_dev);
}
-static void scmi_dev_remove(struct device *dev)
-{
-}
-
struct bus_type scmi_bus_type = {
.name = "scmi_protocol",
.match = scmi_dev_match,
.probe = scmi_dev_probe,
- .remove = scmi_dev_remove,
};
EXPORT_SYMBOL_GPL(scmi_bus_type);
--
2.39.2
next prev parent reply other threads:[~2024-02-15 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 10:33 [PATCH 1/3] driver: make CONFIG_DEBUG_PROBES more useful for removal Ahmad Fatoum
2024-02-15 10:33 ` [PATCH 2/3] drivers: drop simple bus remove in favor of common implementation Ahmad Fatoum
2024-02-15 10:33 ` Ahmad Fatoum [this message]
2024-02-16 11:59 ` [PATCH 1/3] driver: make CONFIG_DEBUG_PROBES more useful for removal Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215103353.2799723-3-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ske@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox