From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 04 Mar 2024 20:06:29 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rhDdt-008dJN-2S for lore@lore.pengutronix.de; Mon, 04 Mar 2024 20:06:29 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhDds-0001dQ-Uw for lore@pengutronix.de; Mon, 04 Mar 2024 20:06:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FnhL477XK9TaMVY0RC6L4T7V++UNKgaqG2nfrvHfe0I=; b=H2QpeSQWY+OCvRRwpPeKGv4SgZ EgBz0SEZY4IrsrkFwibuDvlRGLaIPW+UEQq8iKRLt2yiyNfjhawH0P8FHTsRAccm0HQkSH5E2aMPR /jHyEiAOXzmu2DUu6JJTO66D+c+f3bwjWhKZtXLB3pjedQNaGTcdoO17ojQrGDOdZ82N87U3dRuJA uw9lT0HQhwI/GfMwV236rBPeex2bnwruniu8d4ObyES7I2cQLUxxAuysdif+rbyC84xXSB0rPzqdw z446jodWRCqmMmV/d8YBldj8x4XXXyAz2een5X/LcMs6FO7nI+WTENen8Gki9cNh3hegP4/yGQLV7 SFVgciqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDdL-0000000AKXs-2QgH; Mon, 04 Mar 2024 19:05:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDaS-0000000AITV-2h8e for barebox@bombadil.infradead.org; Mon, 04 Mar 2024 19:02:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=FnhL477XK9TaMVY0RC6L4T7V++UNKgaqG2nfrvHfe0I=; b=ewFT+FATLljYsodydqnK8CiZA6 ah/AYY2sCdmVmdSkE7gFhdKm/ZtiM/5w14/USRuSJOT0f2+inOTRnffZlgIyKQHGR4/ANUwPcmliq wpRyHwbfGXt5c5gcNnKgsTGOK2YrMleEOOYQq76L1k7OLqaBxysgFn0cBQU7yFm3XFCYkKoEuWEhS y/8n8zsogOqJHBqprNu2IVQwlV/ATXNVIdq+nz/WkP9vz2AmRQ1WkXV+5gd/gm0HxgtnUDZVQP6qf dOZn0RDSsc1FmFMNa/8hdl3F/G6iU+26HDphVUsrq1fF4K9tAZIZbSQZggK06vTYPrnd3uPTmdNvc v9K0TRqg==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDaL-000000051vb-2tZ4 for barebox@lists.infradead.org; Mon, 04 Mar 2024 19:02:55 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhDaI-0006Gf-Mt; Mon, 04 Mar 2024 20:02:46 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhDaI-004PLz-7J; Mon, 04 Mar 2024 20:02:46 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rhDYK-00Ed9V-0l; Mon, 04 Mar 2024 20:00:44 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 4 Mar 2024 19:59:11 +0100 Message-Id: <20240304190038.3486881-27-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240304190038.3486881-1-a.fatoum@pengutronix.de> References: <20240304190038.3486881-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_190249_781319_2F977396 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 026/113] fs: fix unreaddir, so readdir returns unread dirent first X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) unreaddir should return a directory entry at the top of the list, so readdir consumes it again, not at the end. Fixes: 7876018f7333 ("fs: implement unreaddir") Signed-off-by: Ahmad Fatoum --- fs/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fs.c b/fs/fs.c index b3eac2e55ad6..bd2f0b6294ff 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -1024,7 +1024,7 @@ int unreaddir(DIR *dir, const struct dirent *d) entry = xzalloc(sizeof(*entry)); entry->d = *d; - list_add_tail(&entry->list, &dir->entries); + list_add(&entry->list, &dir->entries); return 0; } -- 2.39.2