From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 08 Mar 2024 08:36:01 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1riUlt-00DPb7-0X for lore@lore.pengutronix.de; Fri, 08 Mar 2024 08:36:01 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riUls-0008Si-G3 for lore@pengutronix.de; Fri, 08 Mar 2024 08:36:01 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=B8jczcvfYErGO+QdiqymIaoeSTjylosN9W5jKBGf+2A=; b=W98kpDM858TzWCtuo8Vj8aZSOW uLidEQGS12jS0vIKzDHYhQ7L10Wq6mem2M/MMUF+Iry7sQex6FFYT82Ht5FZeac3yL7cCDuuvXeJa aAzqti7Fy7mFlMCuxxDjmwjK+wjrM+F82ljYglXwv+6NZNwiDUhHFATmR0ntZL33dwufMTJyxLt8T McsWSSa8/aCoD6Bb7iFRuT76e6N+KC0FYfr73nrLpn7FpUmqYJE7cM+JO1S/tWLXvw2GAM9lJPp8s DhISkOQHN6UZxygOqhH9HyL1DJqlwUrFdocOdkeltkzKOfPJT19n2dnyfQQEf+M3n7Nj1Zt1gY0G6 QsfjOW7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riUlM-00000008A01-2vbt; Fri, 08 Mar 2024 07:35:28 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riUlH-000000089yG-0vJO for barebox@lists.infradead.org; Fri, 08 Mar 2024 07:35:26 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riUlF-00082T-QX; Fri, 08 Mar 2024 08:35:21 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riUlF-0055q4-EI; Fri, 08 Mar 2024 08:35:21 +0100 Received: from rcz by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1riUlF-00GSLn-1H; Fri, 08 Mar 2024 08:35:21 +0100 From: Rouven Czerwinski To: barebox@lists.infradead.org Cc: Rouven Czerwinski Date: Fri, 8 Mar 2024 08:35:17 +0100 Message-Id: <20240308073518.3922205-1-r.czerwinski@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_233523_279495_53EC3C60 X-CRM114-Status: UNSURE ( 8.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 1/2] crypto: caam: map DMA buffers instead of single_sync X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) With dma api debugging enabled, Barebox complains correctly that the result and desc buffer are never mapped correctly. Add the correct map and unmap sequence instead of the sync single. Signed-off-by: Rouven Czerwinski --- v2: - remove dma_sync_single_for_device() calls drivers/crypto/caam/rng_self_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/caam/rng_self_test.c b/drivers/crypto/caam/rng_self_test.c index b6fcc3bc09..7bb340acbd 100644 --- a/drivers/crypto/caam/rng_self_test.c +++ b/drivers/crypto/caam/rng_self_test.c @@ -186,10 +186,8 @@ int caam_rng_self_test(struct device *dev, const u8 caam_era, const u8 rngvid, construct_rng_self_test_jobdesc(desc, rng_st_dsc, result, desc_size); - dma_sync_single_for_device(dev, (unsigned long)desc, - desc_size * sizeof(*desc), DMA_TO_DEVICE); - dma_sync_single_for_device(dev, (unsigned long)result, - result_size * sizeof(*result), DMA_FROM_DEVICE); + dma_map_single(dev, desc, desc_size * sizeof(*desc), DMA_TO_DEVICE); + dma_map_single(dev, result, result_size * sizeof(*result), DMA_FROM_DEVICE); /* wait for job completion */ ret = caam_jr_enqueue(dev, desc, rng_self_test_done, &job_err); @@ -218,6 +216,8 @@ int caam_rng_self_test(struct device *dev, const u8 caam_era, const u8 rngvid, ret = 0; err: + dma_unmap_single(dev, (dma_addr_t)desc, desc_size * sizeof(*desc), DMA_TO_DEVICE); + dma_unmap_single(dev, (dma_addr_t)result, result_size * sizeof(*result), DMA_FROM_DEVICE); dma_free(desc); dma_free(result); return ret; -- 2.39.2