From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 18 Mar 2024 11:23:33 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rmA9V-00CDKN-1l for lore@lore.pengutronix.de; Mon, 18 Mar 2024 11:23:33 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmA9U-0001Rz-Lz for lore@pengutronix.de; Mon, 18 Mar 2024 11:23:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Dm/kEtpRfyFEs40Bsn8q2ggMqVYEwskNftCIvCxFcK4=; b=lU23+ngSep5EJRD+d8y0eQjPRR foK5QuwE2WVANpU4sn/kuoZfD/DmobE1nj009YQXlACZSdiSLZIJ7oWx2NOoEgl5nyUcAeTKLB7LG O/KI6UEymO59kTPvbbcOxGb+WrqULYNP+GVruUy/OWazXrL/7FYc3n7z16hU9IzVk/GI7MgSD6hs9 ZurVU4Pa0twwDWB5qRh0yz5lgzPSuoWDFVBsIEhyQ6V5K114Em7aDk6hOpsKX6v1mcNb3MNrG3OLF tfGOaXkAvJjbdXd5NukYVeLm8ZztxuME8ZaQaBDkf497wK+/YOLqAkpII0HZ3xWZoxr5xk6NpOFnV ruT8GZow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmA8X-000000087nz-17Ka; Mon, 18 Mar 2024 10:22:33 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmA8K-000000087Jf-3uPY for barebox@lists.infradead.org; Mon, 18 Mar 2024 10:22:24 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=ratatoskr.trumtrar.info) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rmA5O-0006MJ-Al; Mon, 18 Mar 2024 11:19:18 +0100 From: Steffen Trumtrar Date: Mon, 18 Mar 2024 11:18:18 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240318-v2024-02-0-topic-arasan-hs200-support-v4-4-48756863add6@pengutronix.de> References: <20240318-v2024-02-0-topic-arasan-hs200-support-v4-0-48756863add6@pengutronix.de> In-Reply-To: <20240318-v2024-02-0-topic-arasan-hs200-support-v4-0-48756863add6@pengutronix.de> To: barebox@lists.infradead.org Cc: Ahmad Fatoum X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2476; i=s.trumtrar@pengutronix.de; h=from:subject:message-id; bh=1Pr5x2R/90JtF4TEn4NJApGjyYFlDBoBfkWFymCOkik=; b=owGbwMvMwCUmvd38QH3grB+Mp9WSGFJ/iPw+Jt7387R73KYzTyqXF7wSlP6oO9HUYsLKRQ3rZ BiczvxR6ChlYRDjYpAVU2SJXHtIY7PwZ50vx88zwMxhZQIZwsDFKQATWa/LyHDa/r/G1DUqF/Yt WXQ7c+7BzkUSMsEiP+4v75pldsBHRrGW4Z+aVwdLWWvezKevL5/8X110yOvaM703h69rbt5cNaf EdAEXAA== X-Developer-Key: i=s.trumtrar@pengutronix.de; a=openpgp; fpr=59ADC228B313F32CF4C7CF001BB737C07F519AF8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_032221_466822_802370BC X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v4 04/15] mci: arasan: implement 25MHz quirk for zynqmp X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The Arasan on the zynqmp in version 8.9a doesn't meet the timing requirements at 25MHz. It works at 19MHz instead. Add the quirk from linux kernel v6.8-rc4. Signed-off-by: Steffen Trumtrar Reviewed-by: Ahmad Fatoum --- drivers/mci/arasan-sdhci.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c index 98f990b5c1..77e6086165 100644 --- a/drivers/mci/arasan-sdhci.c +++ b/drivers/mci/arasan-sdhci.c @@ -37,6 +37,12 @@ struct arasan_sdhci_host { /* Controller does not have CD wired and will not function normally without */ #define SDHCI_ARASAN_QUIRK_FORCE_CDTEST BIT(0) #define SDHCI_ARASAN_QUIRK_NO_1_8_V BIT(1) +/* + * Some of the Arasan variations might not have timing requirements + * met at 25MHz for Default Speed mode, those controllers work at + * 19MHz instead + */ +#define SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN BIT(2) }; static inline @@ -110,13 +116,30 @@ static int arasan_sdhci_init(struct mci_host *mci, struct device *dev) return 0; } +static void arasan_sdhci_set_clock(struct mci_host *mci, unsigned int clock) +{ + struct arasan_sdhci_host *host = to_arasan_sdhci_host(mci); + + if (host->quirks & SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN) { + /* + * Some of the Arasan variations might not have timing + * requirements met at 25MHz for Default Speed mode, + * those controllers work at 19MHz instead. + */ + if (clock == 25000000) + clock = (25000000 * 19) / 25; + } + + sdhci_set_clock(&host->sdhci, clock, host->sdhci.max_clk); +} + static void arasan_sdhci_set_ios(struct mci_host *mci, struct mci_ios *ios) { struct arasan_sdhci_host *host = to_arasan_sdhci_host(mci); u16 val; if (ios->clock) - sdhci_set_clock(&host->sdhci, ios->clock, host->sdhci.max_clk); + arasan_sdhci_set_clock(mci, ios->clock); sdhci_set_bus_width(&host->sdhci, ios->bus_width); @@ -245,6 +268,9 @@ static int arasan_sdhci_probe(struct device *dev) if (of_property_read_bool(np, "no-1-8-v")) arasan_sdhci->quirks |= SDHCI_ARASAN_QUIRK_NO_1_8_V; + if (of_device_is_compatible(np, "xlnx,zynqmp-8.9a")) + arasan_sdhci->quirks |= SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN; + arasan_sdhci->sdhci.base = IOMEM(iores->start); arasan_sdhci->sdhci.mci = mci; mci->send_cmd = arasan_sdhci_send_cmd; -- 2.43.2