From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/2] mci: mci-core: fix mci_switch_status call
Date: Tue, 26 Mar 2024 12:50:41 +0100 [thread overview]
Message-ID: <20240326-worktree-barebox-bosch-be-ppm4-v1-1-7ea75c487348@pengutronix.de> (raw)
In-Reply-To: <20240326-worktree-barebox-bosch-be-ppm4-v1-0-7ea75c487348@pengutronix.de>
mci_switch_status needs to be called with a boolean instead of a u32.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
drivers/mci/mci-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 414bcf6f06..78c65c8614 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1431,8 +1431,6 @@ static int mmc_select_hs200(struct mci *mci)
/* find out maximum bus width and then try DDR if supported */
err = mci_mmc_select_bus_width(mci);
if (err > 0) {
- u32 status;
-
/* TODO actually set drive strength instead of 0. Currently unsupported. */
val = EXT_CSD_TIMING_HS200 | 0 << EXT_CSD_DRV_STR_SHIFT;
err = mci_switch(mci, EXT_CSD_HS_TIMING, val);
@@ -1452,7 +1450,7 @@ static int mmc_select_hs200(struct mci *mci)
mci_set_ios(mci);
mci_set_clock(mci, mci->host->hs_max_dtr);
- err = mci_switch_status(mci, &status);
+ err = mci_switch_status(mci, true);
/*
* mmc_select_timing() assumes timing has not changed if
--
2.43.2
next prev parent reply other threads:[~2024-03-26 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 11:50 [PATCH 0/2] mci: fix warning and linker error Steffen Trumtrar
2024-03-26 11:50 ` Steffen Trumtrar [this message]
2024-03-26 11:50 ` [PATCH 2/2] mci: arasan: fix build for non-ZynqMP Steffen Trumtrar
2024-03-26 12:34 ` Sascha Hauer
2024-04-02 8:33 ` Sascha Hauer
2024-04-02 8:43 ` Lucas Stach
2024-04-02 8:59 ` Sascha Hauer
2024-04-02 8:20 ` [PATCH 0/2] mci: fix warning and linker error Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326-worktree-barebox-bosch-be-ppm4-v1-1-7ea75c487348@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox