mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/2] mci: remove FIXME in rca description
Date: Wed,  3 Apr 2024 11:03:53 +0200	[thread overview]
Message-ID: <20240403090353.2976380-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240403090353.2976380-1-a.fatoum@pengutronix.de>

The FIXME was added in the commit introducing the file many years ago.
The RCA is a bit special in that it's unused for SPI, reported by the
card for MMC and set by the host for SD. There are comments describing
this in the MCI core, so just explain the abbreviation in the
documentation comment.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/mci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/mci.h b/include/mci.h
index 5781fb8ea381..2274ca8e97d5 100644
--- a/include/mci.h
+++ b/include/mci.h
@@ -564,7 +564,7 @@ struct mci {
 	unsigned scr[2];
 	unsigned csd[4];	/**< card's "card specific data register" */
 	unsigned cid[4];	/**< card's "card identification register" */
-	unsigned short rca;	/* FIXME */
+	unsigned short rca;	/**< relative card address */
 	bool sdio;              /**< card is a SDIO card */
 	bool high_capacity;	/**< high capacity card is connected (OCR -> OCR_HCS) */
 	unsigned tran_speed;	/**< Maximum transfer speed */
-- 
2.39.2




  reply	other threads:[~2024-04-03  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03  9:03 [PATCH 1/2] mci: improve packing of struct mci Ahmad Fatoum
2024-04-03  9:03 ` Ahmad Fatoum [this message]
2024-04-03 12:25 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403090353.2976380-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox