From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 15 Apr 2024 07:36:34 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rwF18-001ZP7-05 for lore@lore.pengutronix.de; Mon, 15 Apr 2024 07:36:34 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwF17-0006YW-9l for lore@pengutronix.de; Mon, 15 Apr 2024 07:36:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QZbYmOqJIbMYf2O+c4YmB+Vq/2Y9xaydCgPJjfMg1G8=; b=R4TTD5jDJKbOoKE8hQv6rydzHL ZF5qPkjUi+S16jKPWgoUylV+YmbMV4YK1p2qgCv0222mCCUxVWq0RyD4zc7YGK2PK8AXuAM4Cry1N Tph57sb75fANoq3RpQrbCxNCuK4qtzQLRkyT8WL6XiMmlYPPCsaXTe0wONxYYPMcyljZoSwMv/+uq Acpd26GpZqFeCFijfkR/2FKOXHpC9NCWvWdImmI4xrO23G3msO48OzA3MtxYkhhNMNYkXr9C/2LlJ vvwQm4TJIOS+vbwgcRGUCNhLWiy1aCVBzVqW4jfT1vWJYOIN1aB22R23HXnkSl11Z6TRYVXGpFBsf qdzJfihQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwF0i-000000071O3-16i3; Mon, 15 Apr 2024 05:36:08 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwF0d-000000071LN-3CsV for barebox@lists.infradead.org; Mon, 15 Apr 2024 05:36:05 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwF0c-0005q2-Ka; Mon, 15 Apr 2024 07:36:02 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwF0c-00CMnA-7f; Mon, 15 Apr 2024 07:36:02 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rwF0c-001YQH-0U; Mon, 15 Apr 2024 07:36:02 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 15 Apr 2024 07:35:54 +0200 Message-Id: <20240415053600.370622-2-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240415053600.370622-1-a.fatoum@pengutronix.de> References: <20240415053600.370622-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240414_223603_828044_BFF15618 X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 1/7] PWM: core: check that struct pwm_chip::devname is set X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) There's no equivalent to devname in the Linux API, but it's required for barebox and not populating the pointer in struct pwm_chip will lead to a crash inside pwmchip_add. Check that the pointer is non-NULL to catch this case. Signed-off-by: Ahmad Fatoum --- drivers/pwm/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index a3f27708e6ef..976357e6062f 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -97,6 +97,9 @@ int pwmchip_add(struct pwm_chip *chip, struct device *dev) struct param_d *p; int ret; + if (!chip->devname) + return -EINVAL; + if (_find_pwm(chip->devname)) return -EBUSY; -- 2.39.2