From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: barebox@lists.infradead.org
Cc: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH] scripts: imx: fix header entry offset
Date: Thu, 18 Apr 2024 10:34:36 +0200 [thread overview]
Message-ID: <20240418083436.171366-1-benjamin.gaignard@collabora.com> (raw)
Header entry is at a fixed offset and doesn't rely on header lenght.
Use header lenght create a bug when adding a signed firmware like
the HDMI firmware for IMX8MQ.
Fixes: 1c18863354dc ("scripts: imx-image: header_v2: add header_len parameter")
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
---
scripts/imx/imx-image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c
index bc2e7af5d6..4f4d5526ed 100644
--- a/scripts/imx/imx-image.c
+++ b/scripts/imx/imx-image.c
@@ -322,7 +322,7 @@ add_header_v2(const struct config_data *data, void *buf, uint32_t offset,
hdr->header.length = htobe16(32);
hdr->header.version = IVT_VERSION;
- hdr->entry = loadaddr + header_len;
+ hdr->entry = loadaddr + HEADER_LEN;
if (dcdsize)
hdr->dcd_ptr = loadaddr + offset + offsetof(struct imx_flash_header_v2, dcd_header);
if (create_usb_image) {
--
2.40.1
next reply other threads:[~2024-04-18 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 8:34 Benjamin Gaignard [this message]
2024-04-18 8:40 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418083436.171366-1-benjamin.gaignard@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox