From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: str@pengutronix.de, mtr@pengutronix.de,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 2/3] mci: core: fix fallback when host doesn't support HS200
Date: Tue, 23 Apr 2024 08:22:05 +0200 [thread overview]
Message-ID: <20240423062206.1518464-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240423062206.1518464-1-a.fatoum@pengutronix.de>
If switching the card into HS200 mode via mmc_select_timing() succeeds,
but switching the host fails in mmc_hs200_tuning(), we are left with
wrong timing information, which prevents us from falling back to a lower
speed mode. Restore the high speed timing on failure to resolve this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/mci/mci-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 57b4c5b99c9c..af0980308866 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1551,6 +1551,11 @@ static int mci_startup_mmc(struct mci *mci)
if (mmc_card_hs200(mci))
ret = mmc_hs200_tuning(mci);
+
+ if (ret) {
+ host->timing = MMC_TIMING_MMC_HS;
+ mci_switch(mci, EXT_CSD_HS_TIMING, EXT_CSD_TIMING_HS);
+ }
}
if (ret || !IS_ENABLED(CONFIG_MCI_TUNING)) {
--
2.39.2
next prev parent reply other threads:[~2024-04-23 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 6:22 [PATCH master 1/3] mci: core: fix fallback when eMMC DDR52 is not possible Ahmad Fatoum
2024-04-23 6:22 ` Ahmad Fatoum [this message]
2024-04-23 6:22 ` [PATCH master 3/3] mci: core: make execute_tuning mandatory for HS200 Ahmad Fatoum
2024-04-23 6:44 ` [PATCH master 1/3] mci: core: fix fallback when eMMC DDR52 is not possible Sascha Hauer
2024-04-23 6:52 ` Ahmad Fatoum
2024-04-30 5:44 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423062206.1518464-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mtr@pengutronix.de \
--cc=str@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox