mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] kbuild: make implicit int to pointer conversion warning an error
Date: Tue, 30 Apr 2024 15:15:40 +0200	[thread overview]
Message-ID: <20240430131540.3597376-1-a.fatoum@pengutronix.de> (raw)

We are guilty of using ints as pointers in readl/writel, but the old
definition of these uses a cast to silence the warning.

Everywhere else there's no reason to allow this, so make this a hard
error always to weed out any instances we may still have.

Disallowing this has the added benefit of making it easier to change API
in barebox: We do not guarantee out-of-tree board code API stability,
but we want changes in API to result in build errors, not in warnings
that may be eaten up by a build system sitting in-between Kbuild and the
user.

While at it, we fix the whitespace for the surrounding lines.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 8e262c17fd50..517b54bd9e6d 100644
--- a/Makefile
+++ b/Makefile
@@ -451,8 +451,9 @@ KBUILD_CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builti
 
 KBUILD_CFLAGS   := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
 		   -fno-strict-aliasing -fno-common -fshort-wchar \
-                   -Werror=implicit-function-declaration -Werror=implicit-int \
-                   -Os -pipe -Wmissing-prototypes -std=gnu11
+		   -Werror=implicit-function-declaration -Werror=implicit-int \
+		   -Werror=int-conversion \
+		   -Os -pipe -Wmissing-prototypes -std=gnu11
 KBUILD_AFLAGS          := -D__ASSEMBLY__
 KBUILD_AFLAGS_KERNEL :=
 KBUILD_CFLAGS_KERNEL :=
-- 
2.39.2




             reply	other threads:[~2024-04-30 13:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 13:15 Ahmad Fatoum [this message]
2024-05-03  7:04 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430131540.3597376-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox