From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2 3/4] mtd: nand: mxc_nand: Add error message if BBT creation fails
Date: Mon, 6 May 2024 16:46:10 +0200 [thread overview]
Message-ID: <20240506144606.1562643-9-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20240506144606.1562643-6-u.kleine-koenig@pengutronix.de>
Then reading from the chip and thus aborting creation of a bad block
table, at inform the user about that with an error message.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mtd/nand/raw/mxc_nand.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
index 8e564fa76a33..faea1c95f95e 100644
--- a/drivers/mtd/nand/raw/mxc_nand.c
+++ b/drivers/mtd/nand/raw/mxc_nand.c
@@ -1569,8 +1569,11 @@ static int checkbad(struct mtd_info *mtd, loff_t ofs)
};
ret = mtd_read_oob(mtd, ofs, &ops);
- if (ret < 0)
+ if (ret < 0) {
+ dev_err(mtd->dev.parent, "Failed to read page at 0x%08x\n",
+ (unsigned int)ofs);
return ret;
+ }
if (buf[2000] != 0xff)
/* block considered bad */
--
2.43.0
next prev parent reply other threads:[~2024-05-06 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 14:46 [PATCH v2 0/4] mtd: nand: mxc_nand: Only automatically create BBT if NAND seems to be pristine Uwe Kleine-König
2024-05-06 14:46 ` [PATCH v2 1/4] mtd: nand: mxc_nand: Improve comment about vendor BBM and address verschwurbelung Uwe Kleine-König
2024-05-06 14:46 ` [PATCH v2 2/4] mtd: nand: mxc_nand: Cleanup code creating bad block table Uwe Kleine-König
2024-05-06 14:46 ` Uwe Kleine-König [this message]
2024-05-06 14:46 ` [PATCH v2 4/4] mtd: nand: mxc_nand: Only automatically create BBT if NAND seems to be pristine Uwe Kleine-König
2024-05-07 7:31 ` [PATCH v2 0/4] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506144606.1562643-9-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox