mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 1/3] mci: core: reset number of parttions on card probe failure
Date: Mon, 13 May 2024 11:58:45 +0200	[thread overview]
Message-ID: <20240513095847.2420044-1-a.fatoum@pengutronix.de> (raw)

mci_part_add records information about MMC hardware partitions and
increments mci->nr_parts by one afterwards.
If starting up the card succeeds, this information is then used to
call mci_register_partition for each added partition.

If card start up fails, registration will be skipped, but mci->nr_parts
is not reset. This means that repeatedly calling device_detect will
overflow the mci->part buffer and overwrite subsequent memory.

Fix this by setting mci->nr_parts to zero on error. We don't need to
touch mci->part as it will be overwritten by subsequent detect attempts.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/mci-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index f6565b2b64dd..66ca98a414ce 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -2363,6 +2363,7 @@ static int mci_card_probe(struct mci *mci)
 		host->clock = 0;	/* disable the MCI clock */
 		mci_set_ios(mci);
 		regulator_disable(host->supply);
+		mci->nr_parts = 0;
 	}
 
 	return rc;
-- 
2.39.2




             reply	other threads:[~2024-05-13  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13  9:58 Ahmad Fatoum [this message]
2024-05-13  9:58 ` [PATCH master 2/3] mci: core: remove HS200 from mci_timing_is_ddr Ahmad Fatoum
2024-05-13  9:58 ` [PATCH master 3/3] ARM64: reloc: fix relocation error for big fat bareboxes Ahmad Fatoum
2024-05-15  5:54 ` [PATCH master 1/3] mci: core: reset number of parttions on card probe failure Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240513095847.2420044-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox