From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 May 2024 09:09:13 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s7VEn-00GuSO-0d for lore@lore.pengutronix.de; Thu, 16 May 2024 09:09:13 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7VEm-0006Tk-8E for lore@pengutronix.de; Thu, 16 May 2024 09:09:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/fdXlpqXceD0HjeUDRH5GTGJUrqxf//VD2ElrQlcdLY=; b=xzEnuiMzQao60mmWverwILSvNu npS8FZOoyMP/Wlm55O9xC1mk3zS1KXgjHfxLcKRmJG1nDe3/wKOkqpgyAvXgWBIUG0DS5My6V56Vt cIEdYqIn5T0Fw0O8jlxSu0l5LH3CLgebsMVkr4GWbFEmyi/3xsTbvdKHz0ZcAGjzoPyDAqkYShvTc HOzZ8zMpLQmmdz1w25Ujl/ygg2hBB6GDxc7QZhSTZvcj54dTgip4mutDz5EtwlEBw+SkJO7XdHXwd N9YbCmIKTvrFDLsFTFl5P8x4e4nogoBfCnnIThtkq54wwhA9Q2EaOBcwzrKLoo2pXrAILZrAfD/1j Fb4Fz2jQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7VEB-00000003wQA-3P4m; Thu, 16 May 2024 07:08:35 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7VE4-00000003wLd-0hTm for barebox@lists.infradead.org; Thu, 16 May 2024 07:08:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7VDz-00061r-VF; Thu, 16 May 2024 09:08:23 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7VDz-001fT4-It; Thu, 16 May 2024 09:08:23 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1s7VDz-00BWfZ-1X; Thu, 16 May 2024 09:08:23 +0200 From: Sascha Hauer To: Barebox List Date: Thu, 16 May 2024 09:08:18 +0200 Message-Id: <20240516070822.2746845-4-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240516070822.2746845-1-s.hauer@pengutronix.de> References: <20240516070822.2746845-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240516_000828_326620_783E455E X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 3/7] ARM: omap: use cdev_open_by_name() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) cdev_by_name() returns a cdev without increasing its reference count. In order to maintain a proper reference counting use cdev_open_by_name() instead and make sure it's closed afterwards when no longer needed. Signed-off-by: Sascha Hauer --- arch/arm/mach-omap/omap_generic.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap/omap_generic.c b/arch/arm/mach-omap/omap_generic.c index 99e14fb540..112c806216 100644 --- a/arch/arm/mach-omap/omap_generic.c +++ b/arch/arm/mach-omap/omap_generic.c @@ -157,13 +157,16 @@ static int omap_env_init(void) device_detect_by_name(diskdev); partname = basprintf("%s.0", diskdev); - cdev = cdev_by_name(partname); + cdev = cdev_open_by_name(partname, O_RDONLY); if (cdev == NULL) { pr_err("Failed to get device %s\n", partname); goto out; } rootpath = cdev_mount_default(cdev, NULL); + + cdev_close(cdev); + if (IS_ERR(rootpath)) { pr_err("Failed to load environment: mount %s failed (%ld)\n", cdev->name, PTR_ERR(rootpath)); -- 2.39.2