mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/7] replace cdev_by_name() with cdev_open_by_name()
Date: Thu, 16 May 2024 16:43:04 +0200	[thread overview]
Message-ID: <20240516144304.gtzxiuhvvjuprxwj@pengutronix.de> (raw)
In-Reply-To: <20240516070822.2746845-1-s.hauer@pengutronix.de>

Hi Sascha,

On 24-05-16, Sascha Hauer wrote:
> As Ahmad noticed cdev_by_name() doesn't increase the reference counting
> on the returned cdev which causes problems further down the road. This
> series replaces some of the easier occurences of cdev_by_name() with
> cdev_open_by_name().

Can we kindly inform the user with a print_once() or so that
cdev_by_name should be replaced with cdev_open_by_name()?

Regards,
  Marco

> Sascha Hauer (7):
>   ARM: Freescale i.MX23 evk: use cdev_open_by_name()
>   ARM: tx28: use cdev_open_by_name()
>   ARM: omap: use cdev_open_by_name()
>   ARM: Rockchip: use cdev_open_by_name()
>   commands: devlookup: use cdev_open_by_name()
>   commands: findmnt: use cdev_open_by_name()
>   bootm: use cdev_open_by_name()
> 
>  arch/arm/boards/freescale-mx23-evk/mx23-evk.c | 13 +++++++------
>  arch/arm/boards/karo-tx28/tx28-stk5.c         | 13 ++++++++-----
>  arch/arm/mach-omap/omap_generic.c             |  5 ++++-
>  arch/arm/mach-rockchip/bbu.c                  |  8 +++++++-
>  commands/devlookup.c                          | 15 ++++++++++-----
>  commands/findmnt.c                            |  3 ++-
>  common/bootm.c                                |  5 ++++-
>  7 files changed, 42 insertions(+), 20 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 



  parent reply	other threads:[~2024-05-16 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  7:08 Sascha Hauer
2024-05-16  7:08 ` [PATCH 1/7] ARM: Freescale i.MX23 evk: use cdev_open_by_name() Sascha Hauer
2024-05-16  7:08 ` [PATCH 2/7] ARM: tx28: " Sascha Hauer
2024-05-16  7:08 ` [PATCH 3/7] ARM: omap: " Sascha Hauer
2024-05-16  7:08 ` [PATCH 4/7] ARM: Rockchip: " Sascha Hauer
2024-05-16  7:08 ` [PATCH 5/7] commands: devlookup: " Sascha Hauer
2024-05-16  7:08 ` [PATCH 6/7] commands: findmnt: " Sascha Hauer
2024-05-16  7:08 ` [PATCH 7/7] bootm: " Sascha Hauer
2024-05-16 14:43 ` Marco Felsch [this message]
2024-05-16 15:01   ` [PATCH 0/7] replace cdev_by_name() with cdev_open_by_name() Sascha Hauer
2024-05-21  6:17 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516144304.gtzxiuhvvjuprxwj@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox