mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] common: hide DEFAULT_COMPRESSION menu
Date: Fri, 17 May 2024 08:21:51 +0200	[thread overview]
Message-ID: <20240517062151.3301660-1-a.fatoum@pengutronix.de> (raw)

CONFIG_DEFAULT_COMPRESSION_* refers to the compression done for
in-barebox binaries and is not useful when barebox proper as a whole is
compressed as in that case, we would have compression applied twice.

For this reason, DEFAULT_COMPRESSION_NONE is the only possible choice in
a PBL-enabled build. Having the choice with only one option is confusing
though, so let's hide the prompt.

Preferably, we'd omit these options in PBL builds completely, but this
seems not easily possible.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/Kconfig b/common/Kconfig
index 67cbbf5197da..366521dadfe1 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -921,8 +921,8 @@ config DEFAULT_ENVIRONMENT
 	  CONFIG_ENV_HANDLING is not enabled.
 
 choice
-	prompt "default compression for in-barebox binaries"
-	default DEFAULT_COMPRESSION_NONE if PBL_IMAGE
+	prompt "default compression for in-barebox binaries" if PBL_IMAGE
+	default DEFAULT_COMPRESSION_NONE
 	default DEFAULT_COMPRESSION_LZO if LZO_DECOMPRESS
 	default DEFAULT_COMPRESSION_XZ if XZ_DECOMPRESS
 	default DEFAULT_COMPRESSION_GZIP if ZLIB
-- 
2.39.2




             reply	other threads:[~2024-05-17  6:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17  6:21 Ahmad Fatoum [this message]
2024-05-21 10:52 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240517062151.3301660-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox