From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 6/7] globalvar: fix memory leak
Date: Fri, 17 May 2024 09:48:23 +0200 [thread overview]
Message-ID: <20240517074824.767767-6-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240517074824.767767-1-a.fatoum@pengutronix.de>
val is copied and then goes out of scope, thereby leaking the buffer it
points at. Free it before that happens.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/globalvar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/globalvar.c b/common/globalvar.c
index a83529f98fe0..79624adcfe6f 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -370,6 +370,7 @@ int nvvar_load(void)
if (ret)
pr_err("failed to create nv variable %s: %s\n",
n, strerror(-ret));
+ free(val);
}
closedir(dir);
--
2.39.2
next prev parent reply other threads:[~2024-05-17 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 7:48 [PATCH 1/7] of: free unflattened overlays after application Ahmad Fatoum
2024-05-17 7:48 ` [PATCH 2/7] of: overlay: do not leak fixed up path Ahmad Fatoum
2024-05-17 7:48 ` [PATCH 3/7] test: self: digest: don't leak digest buffers Ahmad Fatoum
2024-05-17 7:48 ` [PATCH 4/7] test: self: ramfs: fix memory leak Ahmad Fatoum
2024-05-17 7:48 ` [PATCH 5/7] regulator: of_regulator: remove unused allocation Ahmad Fatoum
2024-05-21 6:30 ` Sascha Hauer
2024-05-17 7:48 ` Ahmad Fatoum [this message]
2024-05-17 7:48 ` [PATCH 7/7] power: reset: reboot-mode: fix memory leak Ahmad Fatoum
2024-05-21 6:29 ` [PATCH 1/7] of: free unflattened overlays after application Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517074824.767767-6-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox