From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 28 May 2024 10:58:53 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sBsfV-000siG-2t for lore@lore.pengutronix.de; Tue, 28 May 2024 10:58:53 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBsfU-0001G1-Bk for lore@pengutronix.de; Tue, 28 May 2024 10:58:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date :Subject:To:From:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9zc5RvLjECC+3eg7FazX42okVy2iNshrX9AzbPosuwM=; b=2VHAk4ESxZaTvz 2D7AzFs86u4ZkBlZPjazFiV7l5Lm11Tku/+5W8A9DqHaieOTYLSgVXOwMNSbKwW2fB17VUmWwthYb K7BUOoj984npit2s9y9BRYPnnNmo9WIlbQ3zrl/G1KIZTEkOUt/nGXoBj48iCTQoETafkgDmmXNy4 higb4Il0YSqBOsBRRb4XwkaGC2TxckqIJoCZf4FZ8CB/Ey9sqDCvRNd0b7pSjQfzsRLnbBJ87zjYr gXgIgfGVJke7EaNVcU7vzzfR8dyNzNt96jbTWOGyKJie3r4Tvojd4eY4aegFodBEC+mSyGaaL06pU XYBBORSqjAE2uI0qG5Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBsex-0000000HYkp-1WjI; Tue, 28 May 2024 08:58:19 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBsep-0000000HYgx-3iAx for barebox@lists.infradead.org; Tue, 28 May 2024 08:58:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBsem-0000qN-RE; Tue, 28 May 2024 10:58:08 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBsem-003IsR-Dz; Tue, 28 May 2024 10:58:08 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1sBsem-004v4p-12; Tue, 28 May 2024 10:58:08 +0200 From: Sascha Hauer To: Barebox List Date: Tue, 28 May 2024 10:58:03 +0200 Message-Id: <20240528085806.1172689-7-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240528085806.1172689-1-s.hauer@pengutronix.de> References: <20240528085806.1172689-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_015812_086880_CBF1BF30 X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jianqiang wang Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v3 6/9] net: smc911x: Fix amount of words read from RX FIFO X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) According to the datasheet the packet length field contains the packet length in bytes (and it's also used like this in the driver). This means the number of dwords to read from the FIFO is one quarter of that, or, if we account for non dword aligned packet lengths, as: len = (pktlen + 3) / 4. I have no idea why the code has an additional + 2 when calculating the number of dwords. The corresponding U-Boot driver also does not have this additional + 2, so drop it from the barebox driver as well. Signed-off-by: Sascha Hauer --- drivers/net/smc911x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 767d51761b..1fca58ab84 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -459,7 +459,7 @@ static int smc911x_eth_rx(struct eth_device *edev) smc911x_reg_write(priv, RX_CFG, 0); - tmplen = (pktlen + 2 + 3) / 4; + tmplen = (pktlen + 3) / 4; while(tmplen--) *data++ = smc911x_reg_read(priv, RX_DATA_FIFO); -- 2.39.2