From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH v2 3/4] net: register eth class
Date: Tue, 11 Jun 2024 07:12:36 +0200 [thread overview]
Message-ID: <20240611051237.4126918-4-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20240611051237.4126918-1-s.hauer@pengutronix.de>
Register network devices as class devices. This allows us to implement
for_each_netdev() by iterating over the network class devices.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
include/net.h | 4 ++--
net/eth.c | 6 ++++--
net/ifup.c | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/include/net.h b/include/net.h
index 5a6dd9ca7b..edfea0d105 100644
--- a/include/net.h
+++ b/include/net.h
@@ -599,8 +599,8 @@ void ifdown_edev(struct eth_device *edev);
int ifdown(const char *name);
void ifdown_all(void);
-extern struct list_head netdev_list;
+#define for_each_netdev(netdev) list_for_each_entry(netdev, ð_class.devices, dev.class_list)
-#define for_each_netdev(netdev) list_for_each_entry(netdev, &netdev_list, list)
+extern struct class eth_class;
#endif /* __NET_H__ */
diff --git a/net/eth.c b/net/eth.c
index 26a36474f8..9d7b5994a2 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -21,7 +21,7 @@
#include <linux/ctype.h>
#include <linux/stat.h>
-LIST_HEAD(netdev_list);
+DEFINE_DEV_CLASS(eth_class, "eth");
struct eth_ethaddr {
struct list_head list;
@@ -445,7 +445,7 @@ int eth_register(struct eth_device *edev)
if (edev->init)
edev->init(edev);
- list_add_tail(&edev->list, &netdev_list);
+ class_add_device(ð_class, &edev->dev);
ret = eth_get_registered_ethaddr(edev, ethaddr);
if (!ret)
@@ -512,6 +512,8 @@ void eth_unregister(struct eth_device *edev)
if (IS_ENABLED(CONFIG_OFDEVICE))
free(edev->nodepath);
+ class_remove_device(ð_class, &edev->dev);
+
free(edev->devname);
unregister_device(&edev->dev);
diff --git a/net/ifup.c b/net/ifup.c
index 5b92ee794d..41c1942670 100644
--- a/net/ifup.c
+++ b/net/ifup.c
@@ -358,7 +358,7 @@ int ifup_all(unsigned flags)
closedir(dir);
if ((flags & IFUP_FLAG_FORCE) || net_ifup_force_detect ||
- list_empty(&netdev_list))
+ list_empty(ð_class.devices))
device_detect_all();
/*
--
2.39.2
next prev parent reply other threads:[~2024-06-11 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 5:12 [PATCH v2 0/4] Introduce class devices Sascha Hauer
2024-06-11 5:12 ` [PATCH v2 1/4] net: use for_each_netdev() Sascha Hauer
2024-06-11 5:12 ` [PATCH v2 2/4] base: add class device support Sascha Hauer
2024-06-11 5:12 ` Sascha Hauer [this message]
2024-06-11 5:12 ` [PATCH v2 4/4] watchdog: register watchdog class Sascha Hauer
2024-06-13 6:41 ` [PATCH v2 0/4] Introduce class devices Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611051237.4126918-4-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox