From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2 01/11] FIT: fix missing free in fit_open error path
Date: Thu, 13 Jun 2024 14:58:08 +0200 [thread overview]
Message-ID: <20240613125818.30499-2-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20240613125818.30499-1-m.felsch@pengutronix.de>
Free the handle if read_file_2() fails.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
common/image-fit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/image-fit.c b/common/image-fit.c
index 251fda97b3fc..008804e6a6c3 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -922,6 +922,7 @@ struct fit_handle *fit_open(const char *filename, bool verbose,
max_size);
if (ret && ret != -EFBIG) {
pr_err("unable to read %s: %s\n", filename, strerror(-ret));
+ free(handle);
return ERR_PTR(ret);
}
--
2.39.2
next prev parent reply other threads:[~2024-06-13 14:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 12:58 [PATCH v2 00/11] Add FIT image overlay support Marco Felsch
2024-06-13 12:58 ` Marco Felsch [this message]
2024-06-13 12:58 ` [PATCH v2 02/11] of: overlay: add of.overlay.fitconfigpattern param Marco Felsch
2024-06-13 12:58 ` [PATCH v2 03/11] FIT: skip possible overlay config nodes Marco Felsch
2024-06-17 8:05 ` Sascha Hauer
2024-06-13 12:58 ` [PATCH v2 04/11] of: overlay: make the pattern match function more generic Marco Felsch
2024-06-13 12:58 ` [PATCH v2 05/11] of: overlay: make search dir/path " Marco Felsch
2024-06-13 12:58 ` [PATCH v2 06/11] FIT: expose useful helpers Marco Felsch
2024-06-13 12:58 ` [PATCH v2 07/11] of: overlay: add FIT overlay support Marco Felsch
2024-06-13 12:58 ` [PATCH v2 08/11] of: overlay: drop unnecessary empty check in of_overlay_global_fixup_dir Marco Felsch
2024-06-13 12:58 ` [PATCH v2 09/11] of: overlay: replace filename with an more unique name Marco Felsch
2024-06-13 12:58 ` [PATCH v2 10/11] FIT: save filename during fit_open Marco Felsch
2024-06-17 11:02 ` Sascha Hauer
2024-06-26 10:15 ` Marco Felsch
2024-06-13 12:58 ` [PATCH v2 11/11] FIT: add support to cache opened fit images Marco Felsch
2024-06-17 11:11 ` Sascha Hauer
2024-06-26 10:14 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613125818.30499-2-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox