From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2 4/5] nvmem: allow single and dynamic device ids
Date: Thu, 13 Jun 2024 15:15:30 +0200 [thread overview]
Message-ID: <20240613131531.364894-4-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20240613131531.364894-1-m.felsch@pengutronix.de>
Right now the core implementation always make use of DEVICE_ID_DYNAMIC.
This does not allow us having static devices supplied via the of-aliases
node. Therefore sync the code base with Linux to allow single ids,
albeit the id handling is still different.
While on it fix the nvmem_register_cdev() by using the dev_name() which
honors the DEVICE_ID_* cases else we end up with different names for the
devfs and the device itself.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v2:
- no changes
drivers/nvmem/core.c | 16 +++++++++++-----
include/linux/nvmem-provider.h | 4 ++++
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 8e91d9c0fc8a..c4d397d07080 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -415,10 +415,16 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
if (config->read_only || !config->reg_write || of_property_read_bool(np, "read-only"))
nvmem->read_only = true;
- dev_set_name(&nvmem->dev, config->name);
- nvmem->dev.id = DEVICE_ID_DYNAMIC;
-
- dev_dbg(nvmem->dev.parent, "Registering nvmem device %s\n", config->name);
+ dev_set_name(&nvmem->dev, config->name ? : "nvmem");
+ switch (config->id) {
+ case NVMEM_DEVID_NONE:
+ nvmem->dev.id = DEVICE_ID_SINGLE;
+ break;
+ case NVMEM_DEVID_AUTO:
+ default:
+ nvmem->dev.id = DEVICE_ID_DYNAMIC;
+ break;
+ }
rval = register_device(&nvmem->dev);
if (rval) {
@@ -427,7 +433,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
}
if (!config->cdev) {
- rval = nvmem_register_cdev(nvmem, config->name);
+ rval = nvmem_register_cdev(nvmem, dev_name(&nvmem->dev));
if (rval)
goto err_unregister;
}
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 6cfd38a75dd5..047b6f1902bf 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -17,6 +17,9 @@
struct nvmem_device;
+#define NVMEM_DEVID_NONE (-1)
+#define NVMEM_DEVID_AUTO (-2)
+
/**
* struct nvmem_cell_info - NVMEM cell description
* @name: Name.
@@ -47,6 +50,7 @@ typedef int (*nvmem_cell_post_process_t)(void *priv, const char *id,
struct nvmem_config {
struct device *dev;
const char *name;
+ int id;
bool read_only;
struct cdev *cdev;
int stride;
--
2.39.2
next prev parent reply other threads:[~2024-06-13 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 13:15 [PATCH v2 1/5] nvmem: fix nvmem_register error path Marco Felsch
2024-06-13 13:15 ` [PATCH v2 2/5] nvmem: sync with linux code base Marco Felsch
2024-06-13 13:15 ` [PATCH v2 3/5] nvmem: expose nvmem cells as cdev Marco Felsch
2024-06-14 7:46 ` Sascha Hauer
2024-06-14 10:31 ` Marco Felsch
2024-06-13 13:15 ` Marco Felsch [this message]
2024-06-13 13:15 ` [PATCH v2 5/5] eeprom: at24: fix device name handling Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613131531.364894-4-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox