From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox@lists.infradead.org
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [RFC] spi: spi-fsl-qspi: fix dev_request_mem_resource() usage
Date: Wed, 19 Jun 2024 00:33:57 +0300 [thread overview]
Message-ID: <20240618213357.389435-1-antonynpavlov@gmail.com> (raw)
Here is the code from drivers/spi/spi-fsl-qspi.c:
> res = dev_request_mem_resource(dev, 0);
> q->iobase = IOMEM(res->start);
> if (IS_ERR(q->iobase)) {
> ret = PTR_ERR(q->iobase);
> goto err_put_ctrl;
> }
res can contain error code (not a pointer)
so we can't use IOMEM(res->start) just after
res = dev_request_mem_resource(dev, 0) call.
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
drivers/spi/spi-fsl-qspi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 17e6d1df867..d242035ee00 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -800,15 +800,13 @@ static int fsl_qspi_probe(struct device *dev)
spi_controller_set_devdata(ctlr, q);
/* find the resources */
- res = dev_request_mem_resource(dev, 0);
- q->iobase = IOMEM(res->start);
+ q->iobase = dev_request_mem_region(dev, 0);
if (IS_ERR(q->iobase)) {
ret = PTR_ERR(q->iobase);
goto err_put_ctrl;
}
- res = dev_request_mem_resource(dev, 1);
- q->ahb_addr = IOMEM(res->start);
+ q->ahb_addr = dev_platform_get_and_ioremap_resource(dev, 1, &res);
if (IS_ERR(q->ahb_addr)) {
ret = PTR_ERR(q->ahb_addr);
goto err_put_ctrl;
--
2.39.0
next reply other threads:[~2024-06-18 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 21:33 Antony Pavlov [this message]
2024-07-01 13:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618213357.389435-1-antonynpavlov@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox