From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] mci: core: drop unused parameter members from struct mci
Date: Mon, 1 Jul 2024 09:07:24 +0200 [thread overview]
Message-ID: <20240701070724.134251-1-a.fatoum@pengutronix.de> (raw)
We actually never check the device parameter points again in the MCI
core, so we don' need to keep them in struct mci.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/mci/mci-core.c | 14 ++++++--------
include/mci.h | 2 --
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index b91d51b43a0b..f6f8a6adabb9 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -2417,15 +2417,13 @@ static int mci_card_probe(struct mci *mci)
}
if (has_bootpart) {
- mci->param_boot =
- dev_add_param_enum(&mci->dev, "boot", mci_set_boot,
- NULL, &mci->bootpart, mci_boot_names,
- ARRAY_SIZE(mci_boot_names), mci);
+ dev_add_param_enum(&mci->dev, "boot", mci_set_boot,
+ NULL, &mci->bootpart, mci_boot_names,
+ ARRAY_SIZE(mci_boot_names), mci);
- mci->param_boot_ack =
- dev_add_param_bool(&mci->dev, "boot_ack",
- mci_set_boot_ack, NULL,
- &mci->boot_ack_enable, mci);
+ dev_add_param_bool(&mci->dev, "boot_ack",
+ mci_set_boot_ack, NULL,
+ &mci->boot_ack_enable, mci);
ret = mci_get_partition_setting_completed(mci);
if (ret < 0)
diff --git a/include/mci.h b/include/mci.h
index 70529d065087..773aed896c96 100644
--- a/include/mci.h
+++ b/include/mci.h
@@ -580,8 +580,6 @@ struct mci {
int dsr_imp; /**< DSR implementation state from CSD */
u8 *ext_csd;
int probe;
- struct param_d *param_boot;
- struct param_d *param_boot_ack;
int bootpart;
int boot_ack_enable;
--
2.39.2
next reply other threads:[~2024-07-01 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 7:07 Ahmad Fatoum [this message]
2024-07-01 10:10 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701070724.134251-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox