mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/3] PWM: core: remove needless error checking for device parameter
Date: Mon,  1 Jul 2024 09:35:25 +0200	[thread overview]
Message-ID: <20240701073526.176353-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240701073526.176353-1-a.fatoum@pengutronix.de>

The PWM device is specifically created for purposes of the PWM
framework. There should thus be no naming clashes and -ENOMEM
is not a fatal error there either, because the PWM C API is
still usable without the device parameters.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/pwm/core.c | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 69724e1a5c26..4dd18d9446aa 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -94,7 +94,6 @@ static int set_enable(struct param_d *p, void *priv)
 int pwmchip_add(struct pwm_chip *chip)
 {
 	struct pwm_device *pwm;
-	struct param_d *p;
 	int ret;
 
 	if (!chip->devname)
@@ -117,24 +116,18 @@ int pwmchip_add(struct pwm_chip *chip)
 
 	list_add_tail(&pwm->node, &pwm_list);
 
-	p = dev_add_param_uint32(&pwm->dev, "duty_ns", apply_params,
-			NULL, &pwm->params.duty_cycle, "%u", pwm);
-	if (IS_ERR(p))
-		return PTR_ERR(p);
+	dev_add_param_uint32(&pwm->dev, "duty_ns", apply_params,
+			     NULL, &pwm->params.duty_cycle, "%u", pwm);
 
-	p = dev_add_param_uint32(&pwm->dev, "period_ns", apply_params,
-			NULL, &pwm->params.period, "%u", pwm);
-	if (IS_ERR(p))
-		return PTR_ERR(p);
+	dev_add_param_uint32(&pwm->dev, "period_ns", apply_params,
+			     NULL, &pwm->params.period, "%u", pwm);
 
-	p = dev_add_param_bool(&pwm->dev, "enable", set_enable,
-			NULL, &pwm->params.enabled, pwm);
-	if (IS_ERR(p))
-		return PTR_ERR(p);
+	dev_add_param_bool(&pwm->dev, "enable", set_enable,
+			   NULL, &pwm->params.enabled, pwm);
 
-	p = dev_add_param_bool(&pwm->dev, "inverted", apply_params,
-			       NULL, &pwm->params.polarity, pwm);
-	return PTR_ERR_OR_ZERO(p);
+	dev_add_param_bool(&pwm->dev, "inverted", apply_params,
+			   NULL, &pwm->params.polarity, pwm);
+	return 0;
 }
 EXPORT_SYMBOL_GPL(pwmchip_add);
 
-- 
2.39.2




  reply	other threads:[~2024-07-01  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01  7:35 [PATCH 1/3] e1000: mtd: " Ahmad Fatoum
2024-07-01  7:35 ` Ahmad Fatoum [this message]
2024-07-01  7:35 ` [PATCH 3/3] fpga: bridge: " Ahmad Fatoum
2024-07-01  9:33 ` [PATCH 1/3] e1000: mtd: " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701073526.176353-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox