From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] of: platform: early exit on error
Date: Mon, 1 Jul 2024 09:38:22 +0200 [thread overview]
Message-ID: <20240701073822.177731-1-a.fatoum@pengutronix.de> (raw)
This introduces no functional change, but aligns us with the coding
style, where early exits are preferred and the final return is the
successful one.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/of/platform.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 918607a51883..7e086e9488e6 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -231,15 +231,16 @@ struct device *of_platform_device_create(struct device_node *np,
np->dev = dev;
ret = platform_device_register(dev);
- if (!ret)
- return dev;
+ if (ret) {
+ np->dev = NULL;
+ free_device(dev);
+ if (num_reg)
+ free(res);
+ return NULL;
+ }
- np->dev = NULL;
- free_device(dev);
- if (num_reg)
- free(res);
- return NULL;
+ return dev;
}
struct driver dummy_driver = {
--
2.39.2
next reply other threads:[~2024-07-01 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 7:38 Ahmad Fatoum [this message]
2024-07-01 9:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701073822.177731-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox