From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] globalvar: align parameter names in prototype with definition
Date: Wed, 3 Jul 2024 20:56:02 +0200 [thread overview]
Message-ID: <20240703185602.683272-1-a.fatoum@pengutronix.de> (raw)
The prototype disagreed with the definition, possibly confusing users.
Fix it and while at it, add some missing commas, so the patch diff shows
the definition in the context.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/globalvar.c | 4 ++--
include/globalvar.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/globalvar.c b/common/globalvar.c
index 79624adcfe6f..ab224a27a130 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -309,9 +309,9 @@ static LIST_HEAD(globalvar_deprecated_list);
*
* This function is a helper for globalvars that are renamed from one
* release to another. when a variable @oldname is found in the persistent
- * environment a warning is issued and its value is written to @newname.
+ * environment, a warning is issued and its value is written to @newname.
*
- * Note that when both @oldname and @newname contain values then the values
+ * Note that when both @oldname and @newname contain values, then the values
* existing in @newname are overwritten.
*/
void globalvar_alias_deprecated(const char *oldname, const char *newname)
diff --git a/include/globalvar.h b/include/globalvar.h
index 5fdb70fca911..5b4c168b9170 100644
--- a/include/globalvar.h
+++ b/include/globalvar.h
@@ -44,7 +44,7 @@ int nvvar_remove(const char *name);
void globalvar_print(void);
void dev_param_init_from_nv(struct device *dev, const char *name);
-void globalvar_alias_deprecated(const char *newname, const char *oldname);
+void globalvar_alias_deprecated(const char *oldname, const char *newname);
#else
static inline const char *globalvar_get(const char *name)
--
2.39.2
next reply other threads:[~2024-07-03 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 18:56 Ahmad Fatoum [this message]
2024-07-15 9:07 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703185602.683272-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox