From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 16 Jul 2024 13:59:12 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sTgps-005Qub-2z for lore@lore.pengutronix.de; Tue, 16 Jul 2024 13:59:12 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTgps-0001ma-3r for lore@pengutronix.de; Tue, 16 Jul 2024 13:59:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I/Yhw9pipoRAN/9iF8Th22hbeLYYDuUQRLPN61r3QgA=; b=PbEXWYfWtv8lBhl7pCVuaq9Yuz wiOHOGEB0c38Emt6f2CbtVn424Sn9eJWaGYAGYh5fsi8D2UH5KnM+abtIGgIO49C6VJQDwvzTRJaH I2mdVRu2AmhkJ9zWGsLoCZqXetPEo25GambKXMnCObID3COPjNlj9X5Wki0/6zqoQz9ZfUW6KvvOk bOAWueXx9cj/1vVerF60fX1MC/Lx0PVyarPIaFCrHOP7OlcTHu7Oxhbj1KLzY02ixZXxOnCstE9p6 D8bPrHJss3UxJSrA/fLZ2FmFkzbz3rTKThvBORhe/alLMAFF6V+28TZIktWuhz8rVkFUXUiF921Vb ujM9WoZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTgpQ-0000000AKgj-3woM; Tue, 16 Jul 2024 11:58:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTgpJ-0000000AKc3-287r for barebox@lists.infradead.org; Tue, 16 Jul 2024 11:58:40 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTgpI-0001O6-2F; Tue, 16 Jul 2024 13:58:36 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sTgpH-0007Yw-LT; Tue, 16 Jul 2024 13:58:35 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1sTgpH-008FTm-1r; Tue, 16 Jul 2024 13:58:35 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Tue, 16 Jul 2024 13:58:27 +0200 Message-Id: <20240716115834.1958413-2-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240716115834.1958413-1-a.fatoum@pengutronix.de> References: <20240716115834.1958413-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_045837_592212_A769888D X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 1/8] regmap-mmio: don't call kfree on non kmalloc allocated buffers X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) If we don't use kmalloc() or friends, we shouldn't use kfree() to free the buffer either. Currently, kfree and free are identical, but they are defined in different headers. Signed-off-by: Ahmad Fatoum --- drivers/base/regmap/regmap-mmio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/base/regmap/regmap-mmio.c b/drivers/base/regmap/regmap-mmio.c index 01b0a9963110..9d2ab9cb8dc7 100644 --- a/drivers/base/regmap/regmap-mmio.c +++ b/drivers/base/regmap/regmap-mmio.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include "internal.h" @@ -272,7 +273,7 @@ static struct regmap_mmio_context *regmap_mmio_gen_context(struct device *dev, return ctx; err_free: - kfree(ctx); + free(ctx); return ERR_PTR(ret); } @@ -293,7 +294,7 @@ struct regmap *regmap_init_mmio_clk(struct device *dev, clk = clk_get(dev, clk_id); if (IS_ERR(clk)) { - kfree(ctx); + free(ctx); return ERR_CAST(clk); } -- 2.39.2