From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 5/9] malloc: implement free_sensitive()
Date: Mon, 22 Jul 2024 10:24:01 +0200 [thread overview]
Message-ID: <20240722082405.926111-6-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20240722082405.926111-1-s.hauer@pengutronix.de>
barebox sometimes stores sensitive data in memory. Add a
(k)free_sensitive() function which zeroes out the memory before freeing it.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/dlmalloc.c | 15 +++++++++++++++
common/tlsf_malloc.c | 11 +++++++++++
include/dma.h | 5 +++++
include/linux/slab.h | 5 +++++
include/malloc.h | 1 +
5 files changed, 37 insertions(+)
diff --git a/common/dlmalloc.c b/common/dlmalloc.c
index c41487d54b..0e23399b2b 100644
--- a/common/dlmalloc.c
+++ b/common/dlmalloc.c
@@ -1431,6 +1431,21 @@ void free(void *mem)
frontlink(p, sz, idx, bck, fwd);
}
+void free_sensitive(void *mem)
+{
+ mchunkptr p;
+ size_t size;
+
+ if (!mem)
+ return;
+
+ p = mem2chunk(mem);
+ size = chunksize(p);
+ if (size)
+ memset(mem, size, 0x0);
+
+ free(mem);
+}
/*
Realloc algorithm:
diff --git a/common/tlsf_malloc.c b/common/tlsf_malloc.c
index 981f09de41..5bcbbcd2f8 100644
--- a/common/tlsf_malloc.c
+++ b/common/tlsf_malloc.c
@@ -38,6 +38,17 @@ void free(void *mem)
}
EXPORT_SYMBOL(free);
+void free_sensitive(void *mem)
+{
+ size_t size;
+
+ size = tlsf_block_size(mem);
+ if (size)
+ memset(mem, size, 0x0);
+
+ tlsf_free(tlsf_mem_pool, mem);
+}
+
void *realloc(void *oldmem, size_t bytes)
{
void *mem = tlsf_realloc(tlsf_mem_pool, oldmem, bytes);
diff --git a/include/dma.h b/include/dma.h
index 4fcd114bb6..c2b1bee358 100644
--- a/include/dma.h
+++ b/include/dma.h
@@ -41,6 +41,11 @@ static inline void dma_free(void *mem)
free(mem);
}
+static inline void dma_free_sensitive(void *mem)
+{
+ free_sensitive(mem);
+}
+
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
#define DMA_MASK_NONE 0x0ULL
diff --git a/include/linux/slab.h b/include/linux/slab.h
index a63aad1c34..5e08c7697d 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -62,6 +62,11 @@ static inline void kfree(const void *mem)
dma_free((void *)mem);
}
+static inline void kfree_sensitive(const void *objp)
+{
+ dma_free_sensitive((void *)objp);
+}
+
static inline void *kmem_cache_alloc(struct kmem_cache *cache, gfp_t flags)
{
void *mem = kmalloc(cache->size, flags);
diff --git a/include/malloc.h b/include/malloc.h
index d63853b91e..c25bbf6949 100644
--- a/include/malloc.h
+++ b/include/malloc.h
@@ -7,6 +7,7 @@
void *malloc(size_t) __alloc_size(1);
void free(void *);
+void free_sensitive(void *);
void *realloc(void *, size_t) __realloc_size(2);
void *memalign(size_t, size_t) __alloc_size(2);
void *calloc(size_t, size_t) __alloc_size(1, 2);
--
2.39.2
next prev parent reply other threads:[~2024-07-22 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 8:23 [PATCH 0/9] Add ECDSA support for FIT image verification Sascha Hauer
2024-07-22 8:23 ` [PATCH 1/9] errno: include string for EOPNOTSUPP Sascha Hauer
2024-07-22 8:23 ` [PATCH 2/9] rsatoc: switch to non deprecated openssl API Sascha Hauer
2024-07-22 8:23 ` [PATCH 3/9] rsatoc: rename to keytoc Sascha Hauer
2024-07-22 8:24 ` [PATCH 4/9] keytoc: add ecdsa support Sascha Hauer
2024-07-22 8:24 ` Sascha Hauer [this message]
2024-07-22 8:24 ` [PATCH 6/9] Add elliptic curve cryptography (ECC) helper functions Sascha Hauer
2024-07-22 8:24 ` [PATCH 7/9] crypro: add ECDSA support Sascha Hauer
2024-07-22 8:24 ` [PATCH 8/9] crypto: make RSA a visible option Sascha Hauer
2024-07-22 8:24 ` [PATCH 9/9] fit: Add ecdsa support Sascha Hauer
2024-08-06 6:03 ` [PATCH 0/9] Add ECDSA support for FIT image verification Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722082405.926111-6-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox