mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 8/9] crypto: make RSA a visible option
Date: Mon, 22 Jul 2024 10:24:04 +0200	[thread overview]
Message-ID: <20240722082405.926111-9-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20240722082405.926111-1-s.hauer@pengutronix.de>

With upcoming ECDSA support RSA won't be the only option for FIT image
verification anymore. Make CONFIG_CRYPTO_RSA visible so that the user
can choose. CONFIG_CRYPTO_RSA defaults to yes when FITIMAGE_SIGNATURE
is selected so that existing configs continue to work.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/Kconfig     | 1 -
 common/image-fit.c | 5 +++++
 crypto/Kconfig     | 3 ++-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/common/Kconfig b/common/Kconfig
index 31360892ae..65850f68bd 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -59,7 +59,6 @@ config FITIMAGE
 	select DIGEST
 
 config FITIMAGE_SIGNATURE
-	select CRYPTO_RSA
 	bool
 
 config LOGBUF
diff --git a/common/image-fit.c b/common/image-fit.c
index 4a69049abc..6002440e7e 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -262,6 +262,11 @@ static int fit_check_rsa_signature(struct device_node *sig_node,
 	const char *sig_value;
 	int ret;
 
+	if (!IS_ENABLED(CONFIG_CRYPTO_RSA)) {
+		pr_err("RSA support is disabled, Cannot verify image\n");
+		return -EOPNOTSUPP;
+	}
+
 	sig_value = of_get_property(sig_node, "value", &sig_len);
 	if (!sig_value) {
 		pr_err("signature value not found in %pOF\n", sig_node);
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 32051d8d2b..b6214b229f 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -116,7 +116,8 @@ config CRYPTO_PBKDF2
 	bool
 
 config CRYPTO_RSA
-	bool
+	bool "RSA support"
+	default y if FITIMAGE_SIGNATURE
 
 config CRYPTO_RSA_BUILTIN_KEYS
 	bool
-- 
2.39.2




  parent reply	other threads:[~2024-07-22  8:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  8:23 [PATCH 0/9] Add ECDSA support for FIT image verification Sascha Hauer
2024-07-22  8:23 ` [PATCH 1/9] errno: include string for EOPNOTSUPP Sascha Hauer
2024-07-22  8:23 ` [PATCH 2/9] rsatoc: switch to non deprecated openssl API Sascha Hauer
2024-07-22  8:23 ` [PATCH 3/9] rsatoc: rename to keytoc Sascha Hauer
2024-07-22  8:24 ` [PATCH 4/9] keytoc: add ecdsa support Sascha Hauer
2024-07-22  8:24 ` [PATCH 5/9] malloc: implement free_sensitive() Sascha Hauer
2024-07-22  8:24 ` [PATCH 6/9] Add elliptic curve cryptography (ECC) helper functions Sascha Hauer
2024-07-22  8:24 ` [PATCH 7/9] crypro: add ECDSA support Sascha Hauer
2024-07-22  8:24 ` Sascha Hauer [this message]
2024-07-22  8:24 ` [PATCH 9/9] fit: Add ecdsa support Sascha Hauer
2024-08-06  6:03 ` [PATCH 0/9] Add ECDSA support for FIT image verification Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722082405.926111-9-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox