mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk
Date: Wed, 24 Jul 2024 11:09:32 +0200	[thread overview]
Message-ID: <20240724090932.134375-1-a.fatoum@pengutronix.de> (raw)

ramfs_find_chunk finds the correct chunk and additionally returns via
argument pointers the offset to use and the remaining length.

While correct, the way the remaining len is calculated can be simplified
by using the offset previously calculated:

  data->ofs  +        data->size - pos
  data->size -  pos + data->ofs
  data->size - (pos - data->ofs)
  data->size - (*ofs)

Do that for clarity. No functional change.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ramfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 3223beba7212..a799b23efbcd 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -202,7 +202,7 @@ static struct ramfs_chunk *ramfs_find_chunk(struct ramfs_inode *node,
 	list_for_each_entry_from(data, &node->data, list) {
 		if (data->ofs + data->size > pos) {
 			*ofs = pos - data->ofs;
-			*len = data->ofs + data->size - pos;
+			*len = data->size - *ofs;
 
 			node->current_chunk = data;
 
-- 
2.39.2




             reply	other threads:[~2024-07-24  9:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24  9:09 Ahmad Fatoum [this message]
2024-07-30  8:17 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240724090932.134375-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox