[PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk

[PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk

[Ahmad Fatoum]

ramfs_find_chunk finds the correct chunk and additionally returns via
argument pointers the offset to use and the remaining length.

While correct, the way the remaining len is calculated can be simplified
by using the offset previously calculated:

  data->ofs  +        data->size - pos
  data->size -  pos + data->ofs
  data->size - (pos - data->ofs)
  data->size - (*ofs)

Do that for clarity. No functional change.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ramfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 3223beba7212..a799b23efbcd 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -202,7 +202,7 @@ static struct ramfs_chunk *ramfs_find_chunk(struct ramfs_inode *node,
 	list_for_each_entry_from(data, &node->data, list) {
 		if (data->ofs + data->size > pos) {
 			*ofs = pos - data->ofs;
-			*len = data->ofs + data->size - pos;
+			*len = data->size - *ofs;
 
 			node->current_chunk = data;
 
-- 
2.39.2

Re: [PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk

[Sascha Hauer]

On Wed, 24 Jul 2024 11:09:32 +0200, Ahmad Fatoum wrote:
> ramfs_find_chunk finds the correct chunk and additionally returns via
> argument pointers the offset to use and the remaining length.
> 
> While correct, the way the remaining len is calculated can be simplified
> by using the offset previously calculated:
> 
>   data->ofs  +        data->size - pos
>   data->size -  pos + data->ofs
>   data->size - (pos - data->ofs)
>   data->size - (*ofs)
> 
> [...]

Applied, thanks!

[1/1] fs: ramfs: simplify len calculation in ramfs_find_chunk
      https://git.pengutronix.de/cgit/barebox/commit/?id=e2f6209720d8 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>