[PATCH] rsa: fix deleting RSA keys

[PATCH] rsa: fix deleting RSA keys

[Ahmad Fatoum]

RSA keys are appended onto rsa_keys with rsa_key_add, so it makes sense
that rsa_key_free would remove them from the key ring's linked list.

It's possible to have "standalone" RSA keys outside the key ring, but
those would be global variables which can't be freed anyway.

There are no current users of this function.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 crypto/rsa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/crypto/rsa.c b/crypto/rsa.c
index b798badce0d0..a379b77c9acb 100644
--- a/crypto/rsa.c
+++ b/crypto/rsa.c
@@ -439,6 +439,8 @@ struct rsa_public_key *rsa_of_read_key(struct device_node *node)
 
 void rsa_key_free(struct rsa_public_key *key)
 {
+	list_del(&key->list);
+
 	free(key->modulus);
 	free(key->rr);
 	free(key);
-- 
2.39.2

Re: [PATCH] rsa: fix deleting RSA keys

[Sascha Hauer]

On Wed, 24 Jul 2024 11:47:02 +0200, Ahmad Fatoum wrote:
> RSA keys are appended onto rsa_keys with rsa_key_add, so it makes sense
> that rsa_key_free would remove them from the key ring's linked list.
> 
> It's possible to have "standalone" RSA keys outside the key ring, but
> those would be global variables which can't be freed anyway.
> 
> There are no current users of this function.
> 
> [...]

Applied, thanks!

[1/1] rsa: fix deleting RSA keys
      https://git.pengutronix.de/cgit/barebox/commit/?id=cc4c86c95893 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>