From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 26 Jul 2024 14:26:59 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sXK2F-0038wv-2z for lore@lore.pengutronix.de; Fri, 26 Jul 2024 14:26:59 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sXK2F-0005qh-5Z for lore@pengutronix.de; Fri, 26 Jul 2024 14:26:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ukQvCvtkTSi0HBybfgDeeUfzFUjlssgKlgDP6wvlgbU=; b=fiZM3XB0LJOeAWyvhw9TC3tDyY 29eo7AcCCQyqOGFC8f9xz8W47Oy+NbFSEnJeLbt0cll5u0Yt/ygYq3M8583PNaL0fU8LRQr2kMWlP u9FKBRSNU0TucI4nqca1dMHwxVXDBc2lG3yTnHVHffahQw5ZM8mbxQQTzKfqBxwqgRhoc2zGqZreB utWR6G8JdHY6UXdZVSVjbotZUqIj0/x1yb7uVC858MWS6CwCs0FHXXYbJpRccpgNHypWRZq+nrqFp rqzKmPZYovmQTh5GRXx8+SE3qUedlSElGoshcZtCzRcBVgYWPjB5iD/QWcVn1gg31c2lxYiZBCdj6 EBiyAVxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXK1l-00000003q8N-1g0J; Fri, 26 Jul 2024 12:26:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXK1i-00000003q7V-2d0k for barebox@lists.infradead.org; Fri, 26 Jul 2024 12:26:28 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sXK1h-0005h4-6Y; Fri, 26 Jul 2024 14:26:25 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXK1g-002KoZ-PI; Fri, 26 Jul 2024 14:26:24 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1sXK1g-00ExvY-2E; Fri, 26 Jul 2024 14:26:24 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Casey Reeves , Ahmad Fatoum Date: Fri, 26 Jul 2024 14:26:23 +0200 Message-Id: <20240726122623.3566935-2-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240726122623.3566935-1-a.fatoum@pengutronix.de> References: <20240726122623.3566935-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_052626_673379_2748CE89 X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [RESEND][PATCH 2/2] common: clarify help text for CONFIG_CONSOLE_ACTIVATE_* options X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) CONFIG_CONSOLE_ACTIVATE_NONE is an unfortunate name. The help text explains how consoles are still activated, but omits the main way they are activated: The device tree's /chosen/stdout-path property. Similarly, CONFIG_CONSOLE_ACTIVATE_(FIRST/NONE) don't talk about the implications of selecting them, so reword the help texts to better inform the user. Reported-by: Casey Reeves Signed-off-by: Ahmad Fatoum --- common/Kconfig | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/common/Kconfig b/common/Kconfig index 2dda5ce5743a..fea26262da86 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -818,9 +818,10 @@ config CONSOLE_ACTIVATE_FIRST bool prompt "activate first console on startup" help - Normally on startup all consoles are disabled, so you won't - see anything from barebox starting. Enabling this option - enables the first console. + Select this to activate the first registered console. + On many systems, devices are probed in no strict order, + so you probably should say n here if you are probing + from device tree and have more than one console. config CONSOLE_ACTIVATE_ALL bool @@ -831,6 +832,10 @@ config CONSOLE_ACTIVATE_ALL Only the first registered console will have the full startup log though. + If you have consoles that aren't meant for barebox log output + (e.g. a connected MCU), you will want to say n here and use + CONFIG_ACTIVATE_ALL_FALLBACK or CONFIG_CONSOLE_ACTIVATE_NONE instead. + config CONSOLE_ACTIVATE_ALL_FALLBACK bool prompt "activate all consoles as fallback" @@ -852,9 +857,10 @@ config CONSOLE_ACTIVATE_NONE prompt "leave all consoles disabled" bool help - Leave all consoles disabled on startup. Board code or environment - is responsible for enabling a console. Otherwise you'll get a working - barebox, you just won't see anything. + Leave all consoles disabled on startup. Board code, environment + or the device tree /chosen/stdout-path property will be responsible + for enabling a console. Otherwise you'll get a working barebox, + you just won't see anything. endchoice -- 2.39.2