From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/6] efi: fs: fix determination of read-only files
Date: Wed, 14 Aug 2024 11:24:20 +0200 [thread overview]
Message-ID: <20240814092424.39878-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240814092424.39878-1-a.fatoum@pengutronix.de>
The negation was erroneously applied to only the left-hand argument
falsifying the result. Fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
fs/efi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/efi.c b/fs/efi.c
index 11073e9961c4..cb0eb40da4c2 100644
--- a/fs/efi.c
+++ b/fs/efi.c
@@ -360,7 +360,7 @@ static int efifs_stat(struct device *dev, const char *filename,
s->st_size = info->FileSize;
s->st_mode = 00555;
- if (!info->Attribute & EFI_FILE_READ_ONLY)
+ if (!(info->Attribute & EFI_FILE_READ_ONLY))
s->st_mode |= 00222;
if (info->Attribute & EFI_FILE_DIRECTORY)
--
2.39.2
next prev parent reply other threads:[~2024-08-14 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 9:24 [PATCH 1/6] common: pe: fix use of undefined macro for ARMv7 Ahmad Fatoum
2024-08-14 9:24 ` Ahmad Fatoum [this message]
2024-08-14 9:24 ` [PATCH 3/6] filetype: fix else clause indentation Ahmad Fatoum
2024-08-14 9:24 ` [PATCH 4/6] acpi: fix compilation for 32-bit Ahmad Fatoum
2024-08-14 9:24 ` [PATCH 5/6] i2c: efi: avoid 64-bit division Ahmad Fatoum
2024-08-15 5:53 ` Tomas Marek
2024-08-15 6:57 ` Ahmad Fatoum
2024-08-19 6:16 ` Sascha Hauer
2024-08-14 9:24 ` [PATCH 6/6] net: fsl_enetc: fix compilation for 32-bit Ahmad Fatoum
2024-08-14 11:08 ` [PATCH 1/6] common: pe: fix use of undefined macro for ARMv7 Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814092424.39878-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox