mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: [PATCH] include: linux/iopoll: fix uninitialized warning
Date: Tue,  3 Sep 2024 11:37:12 +0200	[thread overview]
Message-ID: <20240903093712.453901-1-r.czerwinski@pengutronix.de> (raw)

In gcc 13.3 there is a warning that start may be used unitialized:

  include/linux/iopoll.h:42:21: warning: ‘start’ may be used uninitialized [-Wmaybe-uninitialized]
     42 |                     is_timeout(start, ((timeout_us) * USECOND))) { \
        |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The warning is bogus since before usage of start !IN_PBL and
timeout_us != 0 are checked for the case where start is used, but in
this case it is also always initialized to get_time_ns().
Initialize it to zero to silence the warning.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
 include/linux/iopoll.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iopoll.h b/include/linux/iopoll.h
index 96b17dee48..c7dcaec382 100644
--- a/include/linux/iopoll.h
+++ b/include/linux/iopoll.h
@@ -31,7 +31,7 @@
  */
 #define read_poll_timeout(op, val, cond, timeout_us, args...)	\
 ({ \
-	uint64_t start; \
+	uint64_t start = 0; \
 	if (!IN_PBL && (timeout_us) != 0) \
 		start = get_time_ns(); \
 	for (;;) { \
-- 
2.46.0




             reply	other threads:[~2024-09-03  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  9:37 Rouven Czerwinski [this message]
2024-09-03 11:39 ` Sascha Hauer
2024-09-10  8:25 ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903093712.453901-1-r.czerwinski@pengutronix.de \
    --to=r.czerwinski@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox