mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/2] ARM64: asm: mark assembly entry points as functions
Date: Wed,  9 Oct 2024 07:57:31 +0200	[thread overview]
Message-ID: <20241009055731.4115395-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20241009055731.4115395-1-a.fatoum@pengutronix.de>

From: Ahmad Fatoum <ahmad@a3f.at>

ENTRY_PROC_END() is used as counterpart to ENTRY_PROC() to delimit entry
points written in assembly. That macro expands to the END() macro though,
which doesn't explicitly mark the entry point as being a function.

This can lead to objdump -d on the PBL ELF file to not disassemble
the wntry point and instead displaying only a hexdump.

Fix this by using ENDPROC which sets the function type correctly.
This only has effect on the ELF and introduces no functional change for
the objcopied image.

Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 arch/arm/include/asm/barebox-arm64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/barebox-arm64.h b/arch/arm/include/asm/barebox-arm64.h
index 58ff7b9b362b..9b91a693af94 100644
--- a/arch/arm/include/asm/barebox-arm64.h
+++ b/arch/arm/include/asm/barebox-arm64.h
@@ -30,6 +30,6 @@
  * ENTRY_PROC_END - mark end of entry procedure
  */
 #define ENTRY_PROC_END(name) \
-	END(##name)
+	ENDPROC(##name)
 
 #endif /* _BAREBOX_ARM64_H_ */
-- 
2.39.5




  reply	other threads:[~2024-10-09  5:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  5:57 [PATCH 1/2] ARM64: mmuinfo: comment the if clauses decoding PAR_ELx Ahmad Fatoum
2024-10-09  5:57 ` Ahmad Fatoum [this message]
2024-10-14 12:49 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009055731.4115395-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox