mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/2] fixup! video: add dw-hdmi driver
Date: Mon, 14 Oct 2024 12:46:43 +0200	[thread overview]
Message-ID: <20241014104644.2610132-1-a.fatoum@pengutronix.de> (raw)

video: dw-hdmi: drop never defined dw_hdmi_remove

Building without linker garbage collection triggers an error, because
dw_hdmi_remove is never defined.

We remove it, but keep dw_hdmi_unbind as a dummy function as it can
be called by other drivers and then we could make it do something
useful in future.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/video/dw-hdmi.c | 1 -
 include/video/dw_hdmi.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/video/dw-hdmi.c b/drivers/video/dw-hdmi.c
index 2e9f21332c2e..ac4f368f6369 100644
--- a/drivers/video/dw-hdmi.c
+++ b/drivers/video/dw-hdmi.c
@@ -2273,7 +2273,6 @@ EXPORT_SYMBOL_GPL(dw_hdmi_bind);
 
 void dw_hdmi_unbind(struct dw_hdmi *hdmi)
 {
-	dw_hdmi_remove(hdmi);
 }
 EXPORT_SYMBOL_GPL(dw_hdmi_unbind);
 
diff --git a/include/video/dw_hdmi.h b/include/video/dw_hdmi.h
index c7a2ee338160..b2831e60b9ff 100644
--- a/include/video/dw_hdmi.h
+++ b/include/video/dw_hdmi.h
@@ -168,7 +168,6 @@ struct dw_hdmi_plat_data {
 
 struct dw_hdmi *dw_hdmi_probe(struct device *dev,
 			      const struct dw_hdmi_plat_data *plat_data);
-void dw_hdmi_remove(struct dw_hdmi *hdmi);
 void dw_hdmi_unbind(struct dw_hdmi *hdmi);
 struct dw_hdmi *dw_hdmi_bind(struct device *dev,
 			     const struct dw_hdmi_plat_data *plat_data);
-- 
2.39.5




             reply	other threads:[~2024-10-14 10:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 10:46 Ahmad Fatoum [this message]
2024-10-14 10:46 ` [PATCH 2/2] " Ahmad Fatoum
2024-10-14 11:12 ` [PATCH 1/2] " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241014104644.2610132-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox