From: Abdelrahman Youssef via B4 Relay <devnull+abdelrahmanyossef12.gmail.com@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
Subject: [PATCH v6] lib: fix dereferencing of a NULL pointer
Date: Mon, 21 Oct 2024 18:43:03 +0300 [thread overview]
Message-ID: <20241021-null_der-v6-1-8dfc261cfc91@gmail.com> (raw)
From: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
Runtime reported by AddressSanitizer due to time a NULL pointer dereference.
This is the stack trace:
#0 0x5b2550e70c4b in get_param_by_name /barebox/lib/parameter.c:56:2
#1 0x5b2550e70c4b in __dev_add_param /barebox/lib/parameter.c:153:6
#2 0x5b2550e71666 in __dev_add_param_int /barebox/lib/parameter.c:471:8
#3 0x5b2550daece8 in dev_add_param_uint32 /barebox/include/param.h:266:1
#4 0x5b2550daece8 in dos_partition /barebox/common/partitions/dos.c:289:2
#5 0x5b2550dadc62 in fuzz_partition_table_parser /barebox/common/partitions.c:331:10
#6 0x5b2550dadc62 in fuzz_partition_table_parser_ramdisk /barebox/common/partitions.c:344:1
#7 0x5b2550ebb94d in fuzz_test_once /barebox/include/fuzz.h:68:2
#8 0x5b2550ebb94d in fuzz_main /barebox/lib/fuzz.c:38:3
#9 0x5b2550d8eb41 in start_barebox /barebox/common/startup.c:381:3
#10 0x5b2550f4ea6d in sandbox_main (/barebox/images/main.elf+0x411a6d) (BuildId: dfdb3401891b94e86545eddb1502f0815ffd0afb)
#11 0x5b2550f4f2b2 in start_barebox_coop fuzz.c
Signed-off-by: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
---
lib/parameter.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/parameter.c b/lib/parameter.c
index bf9e83152b..21fa9e7e70 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -51,6 +51,9 @@ const char *get_param_type(struct param_d *param)
struct param_d *get_param_by_name(struct device *dev, const char *name)
{
+ if (!dev)
+ return NULL;
+
struct param_d *p;
list_for_each_entry(p, &dev->parameters, list) {
---
base-commit: 9d47ff66c3892c5a6ddd4704993365a797fbeb68
change-id: 20241021-null_der-1378213f0da2
Best regards,
--
Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
next reply other threads:[~2024-10-21 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 15:43 Abdelrahman Youssef via B4 Relay [this message]
2024-10-21 16:14 ` Ahmad Fatoum
2024-10-22 8:14 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021-null_der-v6-1-8dfc261cfc91@gmail.com \
--to=devnull+abdelrahmanyossef12.gmail.com@kernel.org \
--cc=abdelrahmanyossef12@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox