From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Stefan Kerkmann <s.kerkmann@pengutronix.de>
Subject: [PATCH 1/2] block: downgrade noisy debug calls to verbose debug
Date: Mon, 28 Oct 2024 17:17:01 +0100 [thread overview]
Message-ID: <20241028-fix-noisy-debug-calls-v1-1-e84ce4272313@pengutronix.de> (raw)
In-Reply-To: <20241028-fix-noisy-debug-calls-v1-0-e84ce4272313@pengutronix.de>
These debug calls are in the hotpath of any block device interaction,
cluttering the log buffer, slowing down reads/writes and are usually not
interesting while debugging, thus they are downgraded to verbose
debugging.
Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
common/block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/block.c b/common/block.c
index 3101fceea7..3ee33f2bf0 100644
--- a/common/block.c
+++ b/common/block.c
@@ -105,7 +105,7 @@ static struct chunk *chunk_get_cached(struct block_device *blk, sector_t block)
list_for_each_entry(chunk, &blk->buffered_blocks, list) {
if (block >= chunk->block_start &&
block < chunk->block_start + blk->rdbufsize) {
- dev_dbg(blk->dev, "%s: found %llu in %d\n", __func__,
+ dev_vdbg(blk->dev, "%s: found %llu in %d\n", __func__,
block, chunk->num);
/*
* move most recently used entry to the head of the list
@@ -175,7 +175,7 @@ static int block_cache(struct block_device *blk, sector_t block)
chunk->block_start = block & ~blk->blkmask;
- dev_dbg(blk->dev, "%s: %llu to %d\n", __func__, chunk->block_start,
+ dev_vdbg(blk->dev, "%s: %llu to %d\n", __func__, chunk->block_start,
chunk->num);
len = writebuffer_io_len(blk, chunk);
--
2.39.5
next prev parent reply other threads:[~2024-10-28 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 16:17 [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs Stefan Kerkmann
2024-10-28 16:17 ` Stefan Kerkmann [this message]
2024-10-28 16:17 ` [PATCH 2/2] fs: ramfs: downgrade noisy debug calls to verbose debug Stefan Kerkmann
2024-10-28 16:44 ` [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs Ahmad Fatoum
2024-10-28 16:57 ` Stefan Kerkmann
2024-10-29 13:33 ` Sascha Hauer
2024-10-29 13:55 ` Ahmad Fatoum
2024-10-29 14:12 ` Stefan Kerkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028-fix-noisy-debug-calls-v1-1-e84ce4272313@pengutronix.de \
--to=s.kerkmann@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox