From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Stefan Kerkmann <s.kerkmann@pengutronix.de>
Subject: [PATCH 2/2] fs: ramfs: downgrade noisy debug calls to verbose debug
Date: Mon, 28 Oct 2024 17:17:02 +0100 [thread overview]
Message-ID: <20241028-fix-noisy-debug-calls-v1-2-e84ce4272313@pengutronix.de> (raw)
In-Reply-To: <20241028-fix-noisy-debug-calls-v1-0-e84ce4272313@pengutronix.de>
These debug calls are in the hotpath of any ramfs interaction,
cluttering the log buffer, slowing down reads/writes and are usually not
interesting while debugging, thus they are downgraded to verbose
debugging.
Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
fs/ramfs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/ramfs.c b/fs/ramfs.c
index a799b23efb..c1ef7acd91 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -224,14 +224,14 @@ static int ramfs_read(struct device *_dev, FILE *f, void *buf, size_t insize)
unsigned long pos = f->pos;
int size = insize;
- debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
+ pr_vdebug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
while (size) {
data = ramfs_find_chunk(node, pos, &ofs, &len);
if (!data)
return -EINVAL;
- debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
+ pr_vdebug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
now = min(size, len);
@@ -255,14 +255,14 @@ static int ramfs_write(struct device *_dev, FILE *f, const void *buf,
unsigned long pos = f->pos;
int size = insize;
- debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
+ pr_vdebug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
while (size) {
data = ramfs_find_chunk(node, pos, &ofs, &len);
if (!data)
return -EINVAL;
- debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
+ pr_vdebug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
now = min(size, len);
@@ -363,7 +363,7 @@ static int ramfs_truncate(struct device *dev, FILE *f, loff_t size)
if (size > ULONG_MAX)
return -ENOSPC;
- debug("%s: %p cur: %ld new: %lld alloc: %ld\n", __func__, node,
+ pr_vdebug("%s: %p cur: %ld new: %lld alloc: %ld\n", __func__, node,
node->size, size, node->alloc_size);
if (size == node->size)
--
2.39.5
next prev parent reply other threads:[~2024-10-28 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 16:17 [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs Stefan Kerkmann
2024-10-28 16:17 ` [PATCH 1/2] block: downgrade noisy debug calls to verbose debug Stefan Kerkmann
2024-10-28 16:17 ` Stefan Kerkmann [this message]
2024-10-28 16:44 ` [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs Ahmad Fatoum
2024-10-28 16:57 ` Stefan Kerkmann
2024-10-29 13:33 ` Sascha Hauer
2024-10-29 13:55 ` Ahmad Fatoum
2024-10-29 14:12 ` Stefan Kerkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028-fix-noisy-debug-calls-v1-2-e84ce4272313@pengutronix.de \
--to=s.kerkmann@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox