From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 22 Nov 2024 10:54:13 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tEQMf-004yOT-1s for lore@lore.pengutronix.de; Fri, 22 Nov 2024 10:54:13 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEQMf-0006jV-0X for lore@pengutronix.de; Fri, 22 Nov 2024 10:54:13 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=nCPAkBB3fiCvdhQrvxTTEwRgmkACRLAbY8x622WBhBk=; b=t2E0QG/t+1PxFTRRRonoSVfoVY 74U9ltkkfDnYwfOmuBYjQiU6vZNVcGNy6ZFOjMGmZBEfj8JTq5JWfgn6Rs28WqHFFOB9SdTiJHlMH nFG7HlvkVQuYYzhiz2KHIpdrIXgpFMIKOtHFdxElMKLXI1RJVgdDSPMJy40UT5vzWfdRFkKEVjHxW t1BjGBJVwzYh+vNal895NkL0pTkBPVEOZlI6D+c5abDBeGoU9ZMdabIBnnW7BMLrle1EVGNGc3UcM HielQ4YnwwRO0rZo+DGhcE5YXej4xYNRPQAY+rd7Im3ud3U45Nol9G7rCdPwBTg6bGu7ghC9Xdb7a 692LEoyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tEQM4-000000029aZ-2Xj7; Fri, 22 Nov 2024 09:53:36 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tEQM1-000000029ZC-0u70 for barebox@lists.infradead.org; Fri, 22 Nov 2024 09:53:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEQLx-0006Wp-3X; Fri, 22 Nov 2024 10:53:29 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tEQLw-0023G9-2v; Fri, 22 Nov 2024 10:53:28 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tEQLw-00C4VG-2c; Fri, 22 Nov 2024 10:53:28 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Fri, 22 Nov 2024 10:53:26 +0100 Message-Id: <20241122095326.2877232-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241122_015333_249827_5CB65683 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master] usb: typec: fix freeing uninitialized memory X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) When the code was first added, a kzalloc was allocating the memory for the struct device. This has been recently changed to malloc as a shifting of the header caused the function to be no longer defined. malloc() doesn't zero the memory though, leading to a potential freeing of uninitialized memory in dev_set_name. Fix this by using calloc() instead. Reintroducing kzalloc() would be fine too, but calloc() saves some space, because it guarantees a smaller alignment. Fixes: d9fa8b26b60c ("usb: typec: fix compile test with CONFIG_SANDBOX") Signed-off-by: Ahmad Fatoum --- drivers/usb/typec/class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 495ac794622f..9f9b4d6ca8f3 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -142,7 +142,7 @@ struct typec_port *typec_register_port(struct device *parent, const char *alias; int ret; - port = malloc(sizeof(*port)); + port = calloc(sizeof(*port), 1); if (!port) return ERR_PTR(-ENOMEM); -- 2.39.5