From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: bst@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 2/2] startup: do not bring up networking if console input disabled
Date: Fri, 22 Nov 2024 17:05:55 +0100 [thread overview]
Message-ID: <20241122160555.3890597-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20241122160555.3890597-1-a.fatoum@pengutronix.de>
Bringing up network interfaces is a development convenience.
If barebox is configured not to enable any console input by default,
it's reasonable to expect that the user wouldn't appreciate barebox
trying to get a DHCP lease when boot fails.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/startup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/startup.c b/common/startup.c
index 9510824a908a..d71d83c221dc 100644
--- a/common/startup.c
+++ b/common/startup.c
@@ -315,7 +315,7 @@ static int run_init(void)
if (autoboot == AUTOBOOT_BOOT)
run_command("boot");
- if (IS_ENABLED(CONFIG_NET))
+ if (IS_ENABLED(CONFIG_NET) && !IS_ENABLED(CONFIG_CONSOLE_DISABLE_INPUT))
eth_open_all();
if (autoboot == AUTOBOOT_MENU)
--
2.39.5
prev parent reply other threads:[~2024-11-22 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 16:05 [PATCH master 1/2] sandbox: noshell_defconfig: set CONFIG_CONSOLE_DISABLE_INPUT=y Ahmad Fatoum
2024-11-22 16:05 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122160555.3890597-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=bst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox