From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 25 Nov 2024 16:32:44 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tFb4u-000G2O-0K for lore@lore.pengutronix.de; Mon, 25 Nov 2024 16:32:44 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFb4u-0003yP-0b for lore@pengutronix.de; Mon, 25 Nov 2024 16:32:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u7qaU0pFBknZp9xVSTDeGspUz2TTdEZxDZYv8wCQw2k=; b=hDhnKwYE4M6Jf4Xgxf2hzh6FJG NJxioGYdD5WoUOoC8fVKUPly1uYOqZpdi3dMQLdrBEBl79hc5LAuHTR0JCRgxiv9/k+K1yXFRUeDi 1B+tZBSg6n6yIJ/M2YSFqm14iX7hsWoTJxB/KBqlmFi8biHbwPgDhq1/Aw6axaOVj6g9gk6eIkeoS qciFAk4bLuV2Yrx3xPohAjjr8z6NvnIuFc40jpkPV7+8yEvUCp/Ckgy21sVWSIV2yXicolpHJfU/Q UlpPki6kxDmHxGHu6RCvj5KUxk3KxEdl9++w/+nnQgegmt7xTvnRTvYDhu4D4IluBz9Dn8r41WmTr kvPuPpvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tFb4S-00000008Ux8-3Gof; Mon, 25 Nov 2024 15:32:16 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tFb1m-00000008UGi-2yLT for barebox@lists.infradead.org; Mon, 25 Nov 2024 15:29:33 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFb1l-00036k-FS; Mon, 25 Nov 2024 16:29:29 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tFb1k-0006Qc-1b; Mon, 25 Nov 2024 16:29:29 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tFb1k-002dWd-1m; Mon, 25 Nov 2024 16:29:29 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 25 Nov 2024 16:29:27 +0100 Message-Id: <20241125152927.546493-8-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241125152927.546493-1-a.fatoum@pengutronix.de> References: <20241125152927.546493-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241125_072930_755071_4F80C93B X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 7/7] cdev: fix string leaks in devfs links X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The name and part of devfs links are always dynamically allocated, so make sure to free them once we are done with them. Signed-off-by: Ahmad Fatoum --- fs/devfs-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/devfs-core.c b/fs/devfs-core.c index 0bb363d0a9ff..0651be3d8fc4 100644 --- a/fs/devfs-core.c +++ b/fs/devfs-core.c @@ -428,8 +428,11 @@ int devfs_remove(struct cdev *cdev) if (cdev_is_partition(cdev)) list_del(&cdev->partition_entry); - if (cdev->link) + if (cdev->link) { + free(cdev->name); + free(cdev->partname); free(cdev); + } return 0; } -- 2.39.5