From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 02 Dec 2024 13:46:34 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tI5ov-0035Vh-2m for lore@lore.pengutronix.de; Mon, 02 Dec 2024 13:46:34 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tI5ov-000763-GK for lore@pengutronix.de; Mon, 02 Dec 2024 13:46:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=khVEy3VApt5R1+xRT93XsWM8QhmyCPXvLFIP3Pz/XBc=; b=zwVRLPwZg49Nl5pEaBM/YC7cSP VPxarKvhyJL/Ev77TmijYJ/CXdy4Elr420XG7lRYkWkk2EARSrMBvOY0hin3QSrpFKRRAHVZPqZsT ZDfjTb758RYVfb6A02QNSDZs6djl1TsmxcJii1KKjKtA2I+5Iyhm9697OY88stED5gJ8ecNXSdRIa /ZTjbz9rCVjdjMUs7XQJx7jK6E56m88s4iHuVakxEK1ZMRx7uhg+dAo49an5PjjkbUgRJGqBuSTQD UA1la2FYVCneinvDGxm/9vLV8CWfJz1F5mKggpj4VSVsUKuc974gLgBSZyHOowhaLp9j8AMeBT+K+ JsedPAOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tI5oW-000000067mC-2Km7; Mon, 02 Dec 2024 12:46:08 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tI5mZ-000000067Hb-0GF2 for barebox@lists.infradead.org; Mon, 02 Dec 2024 12:44:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tI5mX-0006Ce-Jk; Mon, 02 Dec 2024 13:44:05 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tI5mW-001Ibc-26; Mon, 02 Dec 2024 13:44:05 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tI5mX-007cft-15; Mon, 02 Dec 2024 13:44:05 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 2 Dec 2024 13:44:00 +0100 Message-Id: <20241202124404.1814203-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241202_044407_109499_E5896BA1 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 1/5] kbuild: images: don't compare filesizes if file didn't change X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) If the input file didn't change, there is no point in repeating the file size check and cluttering the log. Therefore use if_changed and remove the extraneous semicolon, which make would then complain about. Signed-off-by: Ahmad Fatoum --- images/Makefile | 2 +- scripts/Makefile.lib | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/images/Makefile b/images/Makefile index 9007911278e2..80ea582728a5 100644 --- a/images/Makefile +++ b/images/Makefile @@ -78,7 +78,7 @@ $(obj)/%.pblb: $(obj)/%.pbl FORCE $(call if_changed,objcopy_bin,$(*F)) $(Q)$(OBJCOPY) -O binary --only-section=.missing_fw $< $@.missing-firmware $(Q)[ -s $@.missing-firmware ] || rm -f $@.missing-firmware - $(call cmd,check_file_size,$@,$(CONFIG_BAREBOX_MAX_IMAGE_SIZE)) + $(call if_changed,check_file_size,$@,$(CONFIG_BAREBOX_MAX_IMAGE_SIZE)) # # For each start symbol create three variables containing the diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index e8a85f3f1bf6..b698161f43f6 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -531,7 +531,7 @@ quiet_cmd_check_file_size = CHKFILESIZE $2 then \ echo "$@ size $$size > maximum size $$max_size" >&2; \ exit 1 ; \ - fi; + fi quiet_cmd_imximage__S_dcd= DCD_S $@ cmd_imximage_S_dcd= \ -- 2.39.5