mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Sven Püschel" <s.pueschel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: "Sven Püschel" <s.pueschel@pengutronix.de>,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Subject: [PATCH] video: mipi_dbi: don't send image before initialization
Date: Tue, 10 Dec 2024 09:04:03 +0100	[thread overview]
Message-ID: <20241210080403.1235658-1-s.pueschel@pengutronix.de> (raw)

Don't send an image to the display before it is initialized, as it can
cause a broken image being stored in the display memory and being shown
while initializing. Instead just damage the image in the flush call but
avoid writing the actual image.

This problem was experienced with a ILI9341 LCD driver and calling the
splash command before enabling the framebuffer. The splash command flushed
out the data, but given no initialization, they were misinterpreted.
After enabling the display, it displayed the broken image for a short time
before being updated. This caused a flickering effect for the viewer.
Switching the command ordering also fixes the problem, but sends an black
image before the actual splash image.

Co-developed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
---
 drivers/video/mipi_dbi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/video/mipi_dbi.c b/drivers/video/mipi_dbi.c
index 9611a402d1..c202ecc1c7 100644
--- a/drivers/video/mipi_dbi.c
+++ b/drivers/video/mipi_dbi.c
@@ -366,6 +366,9 @@ void mipi_dbi_fb_flush(struct fb_info *info)
 		dbidev->damage.y2 = info->yres;
 	}
 
+	if (!info->enabled)
+		return;
+
 	mipi_dbi_fb_dirty(dbidev, info, &dbidev->damage);
 }
 EXPORT_SYMBOL(mipi_dbi_fb_flush);
-- 
2.39.5




             reply	other threads:[~2024-12-10  8:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  8:04 Sven Püschel [this message]
2024-12-12  9:06 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210080403.1235658-1-s.pueschel@pengutronix.de \
    --to=s.pueschel@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox