From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 06 Jan 2025 10:19:09 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tUjGP-00HQeK-1D for lore@lore.pengutronix.de; Mon, 06 Jan 2025 10:19:09 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUjGO-0003Qw-UF for lore@pengutronix.de; Mon, 06 Jan 2025 10:19:09 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zQbKIk3hJPpzIOuaZquALJZubC5wz+BcQpAijKjMl1o=; b=XOSK/KYgIeuWqmjrmmWrGy+I94 fTMbv4/Jv8gEXy8o3EvwWimKOnPLyfMElDOo7iDYk6k7/vGg0KL+asiQ+avwk9uODNrGwxSiX942z 4QphwUnfGXzodNNglZ1d6oaLrLXBdO/kcCNSloNGLDHSGzzEs8uLoTt8tmkcuvaO9Df3+wcKKZrwm z2Kh7G25R0pNfhrqtowIDs6wX/c8CvCKAXIKqCgObeAYwEwTNya3LC9WHNTKK7hYZ45ktALtyQB7w LG2R0f5hn+PFd9N+cPPvADVYOzPmaC7B6cPbZXvCkurAstwPLN9zT9mVBAKxM1FrUcG8ZLGppWpCn hO/CDUFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tUjFy-00000000dtJ-3Ggf; Mon, 06 Jan 2025 09:18:42 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tUjFt-00000000doq-24QD for barebox@lists.infradead.org; Mon, 06 Jan 2025 09:18:39 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUjFs-00030m-76; Mon, 06 Jan 2025 10:18:36 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tUjFr-0078qV-0Y; Mon, 06 Jan 2025 10:18:35 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tUjFr-00EPYv-2k; Mon, 06 Jan 2025 10:18:35 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 6 Jan 2025 10:18:33 +0100 Message-Id: <20250106091835.3434836-4-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250106091835.3434836-1-a.fatoum@pengutronix.de> References: <20250106091835.3434836-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250106_011837_530881_A99AA5FF X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 4/6] fs: return error pointer not NULL from cdev_mount_default X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) cdev_mount_default is documented to return error pointers on errors and that's what's done everywhere inside the function, except for errors from the last call to cdev_get_mount_path. Signed-off-by: Ahmad Fatoum --- fs/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fs.c b/fs/fs.c index a9d2cc7088e3..6d047f197640 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -1152,7 +1152,7 @@ const char *cdev_mount_default(struct cdev *cdev, const char *fsoptions) return ERR_PTR(ret); } - return cdev_get_mount_path(cdev); + return cdev_get_mount_path(cdev) ?: ERR_PTR(-ENODEV); } /* -- 2.39.5