From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: barebox@lists.infradead.org
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>
Subject: [PATCH v2] i2c: at91: Fix driver for SAMA5D2 SoC
Date: Mon, 13 Jan 2025 10:02:16 +0300 [thread overview]
Message-ID: <20250113070216.16303-1-eagle.alexander923@gmail.com> (raw)
Most bits of the AT91 SR status register are cleared after reading,
so we may lose the status at the end of the wait loop.
Let's use the value already readed to check for "completed" status.
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
drivers/i2c/busses/i2c-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index dbc5aa4ddf..8929dbaede 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -276,7 +276,7 @@ static int at91_twi_wait_completion(struct at91_twi_dev *dev)
dev->transfer_status |= status;
- } while (!(at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_TXCOMP));
+ } while (!(status & AT91_TWI_TXCOMP));
at91_disable_twi_interrupts(dev);
--
2.39.1
next reply other threads:[~2025-01-13 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 7:02 Alexander Shiyan [this message]
2025-01-13 13:17 ` Ahmad Fatoum
2025-01-13 13:37 ` Alexander Shiyan
2025-01-14 9:27 ` Ahmad Fatoum
2025-01-14 9:52 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113070216.16303-1-eagle.alexander923@gmail.com \
--to=eagle.alexander923@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox