mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v3] video: simple-panel: add regulator support
Date: Tue, 28 Jan 2025 16:21:24 +0100	[thread overview]
Message-ID: <20250128152124.1145868-1-m.grzeschik@pengutronix.de> (raw)

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

---
v2 -> v3: - reset regulator->power to NULL in case nothing was found
v1 -> v2: - added the missing signed-off-by

 drivers/video/simple-panel.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/video/simple-panel.c b/drivers/video/simple-panel.c
index 7048e2f51b..0973e84056 100644
--- a/drivers/video/simple-panel.c
+++ b/drivers/video/simple-panel.c
@@ -10,6 +10,7 @@
 #include <linux/err.h>
 #include <of.h>
 #include <fb.h>
+#include <regulator.h>
 #include <gpio.h>
 #include <of_gpio.h>
 #include <video/backlight.h>
@@ -25,6 +26,7 @@ struct simple_panel {
 	struct device_node *backlight_node;
 	struct backlight_device *backlight;
 	struct device_node *ddc_node;
+	struct regulator *power;
 	int enable_delay;
 };
 
@@ -49,6 +51,8 @@ static int simple_panel_enable(struct simple_panel *panel)
 	if (panel->enable_delay)
 		mdelay(panel->enable_delay);
 
+	regulator_enable(panel->power);
+
 	if (panel->backlight) {
 		ret = backlight_set_brightness_default(panel->backlight);
 		if (ret)
@@ -65,6 +69,8 @@ static int simple_panel_disable(struct simple_panel *panel)
 	if (panel->backlight)
 		backlight_set_brightness(panel->backlight, 0);
 
+	regulator_disable(panel->power);
+
 	if (gpio_is_valid(panel->enable_gpio))
 		gpio_direction_output(panel->enable_gpio,
 			!panel->enable_active_high);
@@ -154,6 +160,12 @@ static int simple_panel_probe(struct device *dev)
 
 	panel->backlight_node = of_parse_phandle(node, "backlight", 0);
 
+	panel->power = regulator_get(dev, "power");
+	if (IS_ERR(panel->power)) {
+		dev_warn(dev, "Cannot find regulator\n");
+		panel->power = NULL;
+	}
+
 	ret = vpl_register(&panel->vpl);
 	if (ret)
 		return ret;
-- 
2.39.5




                 reply	other threads:[~2025-01-28 15:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250128152124.1145868-1-m.grzeschik@pengutronix.de \
    --to=m.grzeschik@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox